[25536] Fix some warnings in generated code#593
Merged
Conversation
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
changed the title
@default
MiguelCompany
requested review from
cferreiragonz
and removed request for
cferreiragonz
July 20, 2026 12:48
7 tasks
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
force-pushed
the
backport/25536/master
branch
from
July 20, 2026 14:33
bdee0aa to
fca5d99
Compare
MiguelCompany
requested review from
cferreiragonz
and removed request for
cferreiragonz
July 20, 2026 14:36
cferreiragonz
approved these changes
Jul 21, 2026
cferreiragonz
left a comment
cferreiragonz
left a comment
Contributor
There was a problem hiding this comment.
LGTM. CI passed in eProsima/Fast-DDS#6480
|
Tick the box to add this pull request to the merge queue (same as
|
MiguelCompany
added a commit
that referenced
this pull request
Jul 21, 2026
* Refs #25536. Add `f` for default values in float types. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #25536. Remove unnecessary braces. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #25536. Remove more unnecessary braces. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #25536. Add braces for array types. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
7 tasks
MiguelCompany
added a commit
that referenced
this pull request
Jul 21, 2026
* Fix some warnings in generated code (#593) (#594) * Refs #25536. Add `f` for default values in float types. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #25536. Remove unnecessary braces. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #25536. Remove more unnecessary braces. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #25536. Add braces for array types. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 49cb136) # Conflicts: # src/main/java/com/eprosima/fastcdr/idl/templates/FastCdrCommon.stg # src/main/java/com/eprosima/fastdds/idl/templates/eprosima.stg * Fix conflicts Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes some warnings in the generated code introduced by #569.
It adds
fafter default values infloatprimitive types and removes unnecessary braces around default values when used in setter methods before deserialization.Will do the first backport manually due to the submodule update.
Contributor Checklist
Reviewer Checklist