Skip to content

[21325] Remove all code related to FAST CDR v1 - #882

Merged
EduPonz merged 3 commits into
masterfrom
feature/remove_fastcdrv1_code
Jul 24, 2024
Merged

[21325] Remove all code related to FAST CDR v1#882
EduPonz merged 3 commits into
masterfrom
feature/remove_fastcdrv1_code

Conversation

@EduPonz

@EduPonz EduPonz commented Jul 18, 2024 •
edited
Loading

Copy link
Copy Markdown

Description

Fast DDS Docs counterpart of:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@EduPonz EduPonz added this to the v3.0.0 milestone Jul 18, 2024
@EduPonz EduPonz mentioned this pull request Jul 18, 2024
Merged
7 tasks
@EduPonz
EduPonz requested a review from richiware July 20, 2024 05:26
richiware
richiware requested changes Jul 22, 2024
View reviewed changes
Comment thread docs/conf.py Outdated
EduPonz added 3 commits July 24, 2024 09:02
@EduPonz
Refs #21325: fastcdr/config.h is generated with version 2
6086a26 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21325: Define FASTDDS_DOCS_BUILD when calling swig CLI
620bd30 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21325: Apply Ricardo's suggestion
b55f398 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
EduPonz force-pushed the feature/remove_fastcdrv1_code branch from f9e41aa to b55f398 Compare July 24, 2024 07:02
@richiware
richiware self-requested a review July 24, 2024 07:06
richiware
richiware previously approved these changes Jul 24, 2024
View reviewed changes
@EduPonz
EduPonz force-pushed the feature/remove_fastcdrv1_code branch from fd532d4 to f910e66 Compare July 24, 2024 10:18
@EduPonz

EduPonz commented Jul 24, 2024

Copy link
Copy Markdown
Author

A green RTD build with the correct branches here. Dropping the test commit and running CI

@EduPonz
EduPonz force-pushed the feature/remove_fastcdrv1_code branch from f910e66 to b55f398 Compare July 24, 2024 10:34
@EduPonz
EduPonz merged commit f97bc61 into master Jul 24, 2024
@EduPonz
EduPonz deleted the feature/remove_fastcdrv1_code branch July 24, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes
@richiware richiware richiware left review comments

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@EduPonz @richiware @MiguelCompany