Skip to content

Commit 7b27cf7

Browse files
Adjust for API changes in RTPS reader APIs (#140)
* Refs #21120: Adjust for API changes Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21120: Correct typo Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21120. Force fastdds log consumer to `STDOUT`. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
1 parent cce555d commit 7b27cf7

6 files changed

Lines changed: 26 additions & 35 deletions

File tree

.github/workflows/test.meta

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,8 @@
1-
{
2-
"names":
3-
{
4-
"fastdds":
5-
{
6-
"cmake-args": [
7-
"-DSECURITY=ON"
8-
]
9-
},
10-
"fastdds_python":
11-
{
12-
"cmake-args": [
13-
"-DBUILD_TESTING=ON"
14-
]
15-
}
16-
}
17-
}
1+
names:
2+
fastdds:
3+
cmake-args:
4+
- "-DSECURITY=ON"
5+
- "-DLOG_CONSUMER_DEFAULT=STDOUT"
6+
fastdds_python:
7+
cmake-args:
8+
- "-DBUILD_TESTING=ON"

fastdds_python/test/api/test_domainparticipant.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ def test_create_publisher_with_profile(participant):
202202

203203
# Failure
204204
publisher = participant.create_publisher_with_profile(
205-
'no_exits_profile')
205+
'no_exists_profile')
206206
assert(publisher is None)
207207

208208
# Overload 1
@@ -436,7 +436,7 @@ def test_create_subscriber_with_profile(participant):
436436

437437
# Failure
438438
subscriber = participant.create_subscriber_with_profile(
439-
'no_exits_profile')
439+
'no_exists_profile')
440440
assert(subscriber is None)
441441

442442
# Overload 1

fastdds_python/test/api/test_domainparticipantfactory.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,10 @@ def test_create_participant_with_profile():
125125

126126
# Failure
127127
participant = factory.create_participant_with_profile(
128-
'no_exits_profile')
128+
'no_exists_profile')
129129
assert(participant is None)
130130
participant = factory.create_participant_with_profile(
131-
0, 'no_exits_profile')
131+
0, 'no_exists_profile')
132132
assert(participant is None)
133133

134134
# Overload 1

fastdds_python/test/api/test_publisher.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ def test_create_datawriter_with_profile(topic, publisher):
219219

220220
# Failure
221221
datawriter = publisher.create_datawriter_with_profile(
222-
topic, 'no_exits_profile')
222+
topic, 'no_exists_profile')
223223
assert(datawriter is None)
224224

225225
# Overload 1

fastdds_python/test/api/test_qos.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -153,25 +153,25 @@ def test_datareader_qos():
153153
datareader_qos.durability_service().service_cleanup_delay.nanosec)
154154

155155
# .reliable_reader_qos
156-
datareader_qos.reliable_reader_qos().times.initialAcknackDelay.seconds = 34
157-
datareader_qos.reliable_reader_qos().times.initialAcknackDelay.nanosec = 32
158-
datareader_qos.reliable_reader_qos().times.heartbeatResponseDelay. \
156+
datareader_qos.reliable_reader_qos().times.initial_acknack_delay.seconds = 34
157+
datareader_qos.reliable_reader_qos().times.initial_acknack_delay.nanosec = 32
158+
datareader_qos.reliable_reader_qos().times.heartbeat_response_delay. \
159159
seconds = 432
160-
datareader_qos.reliable_reader_qos().times.heartbeatResponseDelay. \
160+
datareader_qos.reliable_reader_qos().times.heartbeat_response_delay. \
161161
nanosec = 43
162162
datareader_qos.reliable_reader_qos().disable_positive_ACKs.enabled = True
163163
datareader_qos.reliable_reader_qos().disable_positive_ACKs.duration. \
164164
seconds = 13
165165
datareader_qos.reliable_reader_qos().disable_positive_ACKs.duration. \
166166
nanosec = 320
167167
assert(34 == datareader_qos.reliable_reader_qos().times.
168-
initialAcknackDelay.seconds)
168+
initial_acknack_delay.seconds)
169169
assert(32 == datareader_qos.reliable_reader_qos().times.
170-
initialAcknackDelay.nanosec)
170+
initial_acknack_delay.nanosec)
171171
assert(432 == datareader_qos.reliable_reader_qos().times.
172-
heartbeatResponseDelay.seconds)
172+
heartbeat_response_delay.seconds)
173173
assert(43 == datareader_qos.reliable_reader_qos().times.
174-
heartbeatResponseDelay.nanosec)
174+
heartbeat_response_delay.nanosec)
175175
assert(datareader_qos.reliable_reader_qos().
176176
disable_positive_ACKs.enabled)
177177
assert(13 == datareader_qos.reliable_reader_qos().
@@ -389,13 +389,13 @@ def test_datareader_qos():
389389

390390
# .reliable_reader_qos
391391
assert(34 == default_datareader_qos.reliable_reader_qos().times.
392-
initialAcknackDelay.seconds)
392+
initial_acknack_delay.seconds)
393393
assert(32 == default_datareader_qos.reliable_reader_qos().times.
394-
initialAcknackDelay.nanosec)
394+
initial_acknack_delay.nanosec)
395395
assert(432 == default_datareader_qos.reliable_reader_qos().times.
396-
heartbeatResponseDelay.seconds)
396+
heartbeat_response_delay.seconds)
397397
assert(43 == default_datareader_qos.reliable_reader_qos().times.
398-
heartbeatResponseDelay.nanosec)
398+
heartbeat_response_delay.nanosec)
399399
assert(default_datareader_qos.reliable_reader_qos().
400400
disable_positive_ACKs.enabled)
401401
assert(13 == default_datareader_qos.reliable_reader_qos().

fastdds_python/test/api/test_subscriber.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ def test_create_datareader_with_profile(topic, subscriber):
222222

223223
# Failure
224224
datareader = subscriber.create_datareader_with_profile(
225-
topic, 'no_exits_profile')
225+
topic, 'no_exists_profile')
226226
assert(datareader is None)
227227

228228
# Overload 1

0 commit comments

Comments
 (0)