Skip to content

Commit 9214250

Browse files
Update DataWriter::write return value as ReturnCode_t (#158)
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
1 parent 7cbeb21 commit 9214250

2 files changed

Lines changed: 13 additions & 13 deletions

File tree

fastdds_python/test/api/test_datareader.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -685,7 +685,7 @@ def test_get_first_untaken(transient_datareader_qos, datareader,
685685

686686
sample = pytest.dds_type.CompleteTestType()
687687
sample.int16_field(255)
688-
assert(datawriter.write(sample))
688+
assert(fastdds.RETCODE_OK == datawriter.write(sample))
689689

690690
assert(datareader.wait_for_unread_message(
691691
fastdds.Duration_t(5, 0)))
@@ -968,7 +968,7 @@ def test_get_unread_count(transient_datareader_qos, datareader,
968968

969969
sample = pytest.dds_type.CompleteTestType()
970970
sample.int16_field(255)
971-
assert(datawriter.write(sample))
971+
assert(fastdds.RETCODE_OK == datawriter.write(sample))
972972

973973
assert(datareader.wait_for_unread_message(
974974
fastdds.Duration_t(5, 0)))
@@ -983,7 +983,7 @@ def test_is_sample_valid(transient_datareader_qos, datareader,
983983
"""
984984
sample = pytest.dds_type.CompleteTestType()
985985
sample.int16_field(255)
986-
assert(datawriter.write(sample))
986+
assert(fastdds.RETCODE_OK == datawriter.write(sample))
987987

988988
assert(datareader.wait_for_unread_message(
989989
fastdds.Duration_t(5, 0)))
@@ -1043,7 +1043,7 @@ def test_read(transient_datareader_qos, datareader,
10431043

10441044
sample = pytest.dds_type.CompleteTestType()
10451045
fill_keyed_complete_test_type(sample, cdr_version)
1046-
assert(datawriter.write(sample))
1046+
assert(fastdds.RETCODE_OK == datawriter.write(sample))
10471047

10481048
assert(datareader.wait_for_unread_message(
10491049
fastdds.Duration_t(5, 0)))
@@ -1123,7 +1123,7 @@ def test_read_next_instance(transient_datareader_qos, test_keyed_type,
11231123

11241124
sample = pytest.dds_type.KeyedCompleteTestType()
11251125
fill_keyed_complete_test_type(sample, cdr_version)
1126-
assert(datawriter.write(sample))
1126+
assert(fastdds.RETCODE_OK == datawriter.write(sample))
11271127

11281128
assert(datareader.wait_for_unread_message(
11291129
fastdds.Duration_t(5, 0)))
@@ -1157,7 +1157,7 @@ def test_read_next_sample(transient_datareader_qos, datareader,
11571157

11581158
sample = pytest.dds_type.CompleteTestType()
11591159
fill_keyed_complete_test_type(sample, cdr_version)
1160-
assert(datawriter.write(sample))
1160+
assert(fastdds.RETCODE_OK == datawriter.write(sample))
11611161

11621162
assert(datareader.wait_for_unread_message(
11631163
fastdds.Duration_t(5, 0)))
@@ -1189,7 +1189,7 @@ def test_take(transient_datareader_qos, datareader,
11891189

11901190
sample = pytest.dds_type.CompleteTestType()
11911191
fill_keyed_complete_test_type(sample, cdr_version)
1192-
assert(datawriter.write(sample))
1192+
assert(fastdds.RETCODE_OK == datawriter.write(sample))
11931193

11941194
assert(datareader.wait_for_unread_message(
11951195
fastdds.Duration_t(5, 0)))
@@ -1269,7 +1269,7 @@ def test_take_next_instance(transient_datareader_qos, test_keyed_type,
12691269

12701270
sample = pytest.dds_type.KeyedCompleteTestType()
12711271
fill_keyed_complete_test_type(sample, cdr_version)
1272-
assert(datawriter.write(sample))
1272+
assert(fastdds.RETCODE_OK == datawriter.write(sample))
12731273

12741274
assert(datareader.wait_for_unread_message(
12751275
fastdds.Duration_t(5, 0)))
@@ -1303,7 +1303,7 @@ def test_take_next_sample(transient_datareader_qos, datareader,
13031303

13041304
sample = pytest.dds_type.CompleteTestType()
13051305
fill_keyed_complete_test_type(sample, cdr_version)
1306-
assert(datawriter.write(sample))
1306+
assert(fastdds.RETCODE_OK == datawriter.write(sample))
13071307

13081308
assert(datareader.wait_for_unread_message(
13091309
fastdds.Duration_t(5, 0)))

fastdds_python/test/api/test_datawriter.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def test_clear_history(keep_all_datawriter_qos, datawriter):
118118
"""
119119
sample = pytest.dds_type.CompleteTestType()
120120
sample.int16_field(4)
121-
assert(datawriter.write(sample))
121+
assert(fastdds.RETCODE_OK == datawriter.write(sample))
122122
assert([fastdds.RETCODE_OK, 1] ==
123123
datawriter.clear_history())
124124

@@ -497,7 +497,7 @@ def test_wait_for_acknowledgments(test_keyed_type, datawriter):
497497
# Overload 1
498498
sample = pytest.dds_type.KeyedCompleteTestType()
499499
sample.id(3)
500-
assert(datawriter.write(sample))
500+
assert(fastdds.RETCODE_OK == datawriter.write(sample))
501501
assert(fastdds.RETCODE_OK ==
502502
datawriter.wait_for_acknowledgments(fastdds.Duration_t(1, 0)))
503503

@@ -517,7 +517,7 @@ def test_write(test_keyed_type, datawriter):
517517
"""
518518
# Overload 1
519519
sample = pytest.dds_type.KeyedCompleteTestType()
520-
assert(datawriter.write(sample))
520+
assert(fastdds.RETCODE_OK == datawriter.write(sample))
521521

522522
# Overload 2
523523
sample = pytest.dds_type.KeyedCompleteTestType()
@@ -530,7 +530,7 @@ def test_write(test_keyed_type, datawriter):
530530
sequence_number.low = 1
531531
params.related_sample_identity().writer_guid(guid)
532532
params.related_sample_identity().sequence_number(sequence_number)
533-
assert(datawriter.write(sample, params))
533+
assert(fastdds.RETCODE_OK == datawriter.write(sample, params))
534534

535535
# Overload 3
536536
sample = pytest.dds_type.KeyedCompleteTestType()

0 commit comments

Comments
 (0)