Skip to content

Commit dbeb9ba

Browse files
committed
Refs #23703. Apply suggestion.
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
1 parent 8bbf5e4 commit dbeb9ba

15 files changed

Lines changed: 134 additions & 2368 deletions

fastdds_python_examples/RPCExample/calculator.idl

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,10 @@ module calculator_base
3232
// Returns the result of value1 - value2
3333
long subtraction(in long value1, in long value2) raises(OverflowException);
3434
};
35-
36-
interface BasicCalculator : Adder, Subtractor
37-
{
38-
// Returns the minimum and maximum representable values
39-
void representation_limits(out long min_value, out long max_value);
40-
};
4135
};
4236

43-
interface Calculator : calculator_base::BasicCalculator
37+
interface Calculator : calculator_base::Adder, calculator_base::Subtractor
4438
{
39+
// Returns the minimum and maximum representable values
40+
void representation_limits(out long min_value, out long max_value);
4541
};

fastdds_python_examples/RPCExample/generated_code/CMakeLists.txt

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,6 @@ find_package(fastdds 3 REQUIRED)
4141

4242
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
4343

44-
if(NOT WIN32)
45-
# Default values for shared library suffix in MacOS
46-
if(${CMAKE_SYSTEM_NAME} STREQUAL "Darwin")
47-
set(CMAKE_SHARED_LIBRARY_SUFFIX ".so")
48-
endif()
49-
endif()
50-
5144
#Create library for C++ types
5245
add_library(${PROJECT_NAME} SHARED
5346
calculatorTypeObjectSupport.cxx

fastdds_python_examples/RPCExample/generated_code/calculator.hpp

Lines changed: 8 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -152,30 +152,32 @@ class eProsima_user_DllExport Subtractor
152152

153153

154154

155+
} // namespace calculator_base
156+
155157
namespace detail {
156158

157-
struct BasicCalculator_representation_limits_Out;
159+
struct Calculator_representation_limits_Out;
158160

159161
} // namespace detail
160162

161163
/*!
162-
* @brief This class represents the interface BasicCalculator defined by the user in the IDL file.
164+
* @brief This class represents the interface Calculator defined by the user in the IDL file.
163165
* @ingroup calculator
164166
*/
165-
class eProsima_user_DllExport BasicCalculator : public calculator_base::Adder, public calculator_base::Subtractor
167+
class eProsima_user_DllExport Calculator : public calculator_base::Adder, public calculator_base::Subtractor
166168
{
167169
public:
168-
virtual ~BasicCalculator() = default;
170+
virtual ~Calculator() = default;
169171

170172

171-
virtual eprosima::fastdds::dds::rpc::RpcFuture<calculator_base::detail::BasicCalculator_representation_limits_Out> representation_limits(
173+
virtual eprosima::fastdds::dds::rpc::RpcFuture<detail::Calculator_representation_limits_Out> representation_limits(
172174
) = 0;
173175

174176
};
175177

176178
namespace detail {
177179

178-
struct BasicCalculator_representation_limits_Out
180+
struct Calculator_representation_limits_Out
179181
{
180182
int32_t min_value;
181183
int32_t max_value;
@@ -185,21 +187,6 @@ struct BasicCalculator_representation_limits_Out
185187
} // namespace detail
186188

187189

188-
} // namespace calculator_base
189-
190-
/*!
191-
* @brief This class represents the interface Calculator defined by the user in the IDL file.
192-
* @ingroup calculator
193-
*/
194-
class eProsima_user_DllExport Calculator : public calculator_base::BasicCalculator
195-
{
196-
public:
197-
virtual ~Calculator() = default;
198-
199-
};
200-
201-
202-
203190
#endif // _FAST_DDS_GENERATED_CALCULATOR_HPP_
204191

205192

fastdds_python_examples/RPCExample/generated_code/calculator.i

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,12 @@ class RpcFuture {
132132

133133
}
134134

135-
%shared_ptr(eprosima::fastdds::dds::rpc::RpcFuture<calculator_base::detail::BasicCalculator_representation_limits_Out>);
136-
%template(calculator_base_detail_BasicCalculator_representation_limits_Out_rpc_future) eprosima::fastdds::dds::rpc::RpcFuture<calculator_base::detail::BasicCalculator_representation_limits_Out>;
135+
%shared_ptr(eprosima::fastdds::dds::rpc::RpcFuture<detail::Calculator_representation_limits_Out>);
136+
%template(detail_Calculator_representation_limits_Out_rpc_future) eprosima::fastdds::dds::rpc::RpcFuture<detail::Calculator_representation_limits_Out>;
137137

138-
%typemap(out, optimal="1") eprosima::fastdds::dds::rpc::RpcFuture<calculator_base::detail::BasicCalculator_representation_limits_Out> {
138+
%typemap(out, optimal="1") eprosima::fastdds::dds::rpc::RpcFuture<detail::Calculator_representation_limits_Out> {
139139
std::shared_ptr<$1_ltype> *smartresult = new std::shared_ptr<$1_ltype>(new $1_ltype($1));
140-
$result = SWIG_NewPointerObj(SWIG_as_voidptr(smartresult), $descriptor(std::shared_ptr< eprosima::fastdds::dds::rpc::RpcFuture<calculator_base::detail::BasicCalculator_representation_limits_Out>> *), SWIG_POINTER_OWN);
140+
$result = SWIG_NewPointerObj(SWIG_as_voidptr(smartresult), $descriptor(std::shared_ptr< eprosima::fastdds::dds::rpc::RpcFuture<detail::Calculator_representation_limits_Out>> *), SWIG_POINTER_OWN);
141141
}
142142

143143
%shared_ptr(eprosima::fastdds::dds::rpc::RpcFuture<int32_t>);
@@ -172,13 +172,6 @@ namespace swig {
172172

173173

174174

175-
%shared_ptr(calculator_base::BasicCalculator);
176-
%shared_ptr(calculator_base::BasicCalculatorServer_IServerImplementation);
177-
%shared_ptr(calculator_base::BasicCalculatorServerImplementation);
178-
%feature("director") calculator_base::BasicCalculatorServerImplementation;
179-
180-
181-
182175
%shared_ptr(Calculator);
183176
%shared_ptr(CalculatorServer_IServerImplementation);
184177
%shared_ptr(CalculatorServerImplementation);

0 commit comments

Comments
 (0)