Skip to content

[21128] Adjust for Fast DDS public headers migration to .hpp - #148

Merged
EduPonz merged 2 commits into
mainfrom
feature/21128
Jun 27, 2024
Merged

[21128] Adjust for Fast DDS public headers migration to .hpp#148
EduPonz merged 2 commits into
mainfrom
feature/21128

Conversation

@JesusPoderoso

@JesusPoderoso JesusPoderoso commented Jun 21, 2024 •
edited by EduPonz
Loading

Copy link
Copy Markdown
Contributor

Description

This PR is the counterpart of the following Fast DDS pull request in this repository:

Contributor Checklist

  • [x Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • ❌ Changes are API compatible.
  • N/A* Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v2.0.0 milestone Jun 21, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jun 21, 2024
@JesusPoderoso JesusPoderoso mentioned this pull request Jun 21, 2024
Merged
8 tasks
@JesusPoderoso
Refs #2112: Update headers from .h to .hpp
6d1595e 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
EduPonz
EduPonz previously approved these changes Jun 26, 2024
View reviewed changes

@EduPonz EduPonz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso JesusPoderoso changed the title [21128] Make all public headers .hpp [21128] Adjust for Fast DDS public headers migration to .hpp Jun 26, 2024
@JesusPoderoso
Refs #21128: Update types with Gen's PR
5f71c62 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@EduPonz
EduPonz merged commit 3041463 into main Jun 27, 2024
@EduPonz
EduPonz deleted the feature/21128 branch June 27, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@EduPonz EduPonz EduPonz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@JesusPoderoso JesusPoderoso

Labels

None yet

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@JesusPoderoso @EduPonz