Skip to content

[#25501] Stabilize flaky Fast DDS Spy Windows application tests in CI - #152

Closed
Danipiza wants to merge 7 commits into
mainfrom
ci/execute-tools
Closed

[#25501] Stabilize flaky Fast DDS Spy Windows application tests in CI#152
Danipiza wants to merge 7 commits into
mainfrom
ci/execute-tools

Conversation

@Danipiza

@Danipiza Danipiza commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Description

This PR reduces flakiness in the Fast DDS Spy application tests on Windows CI.

GitHub Actions on windows-2022 was showing flaky failures in Fast DDS Spy application tests that do not reproduce reliably locally. The failures were concentrated in DDS discovery-dependent one-shot tests

Changes

  • Add a short startup delay before launching the spy when DDS publisher-based tests are used
  • Increase the shared discovery time used by DDS-backed application tests
  • Normalize empty CLI output so '' and '\n' are treated equivalently
  • Improve one-shot test diagnostics by printing stderr on timeout

…banner

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.08%. Comparing base (1c51730) to head (04fcba7).

Files with missing lines Patch % Lines
fastddsspy_tool/src/cpp/tool/Controller.cpp 78.57% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   62.82%   58.08%   -4.74%     
==========================================
  Files          29       28       -1     
  Lines        2480     1942     -538     
  Branches     1068      773     -295     
==========================================
- Hits         1558     1128     -430     
+ Misses        363      330      -33     
+ Partials      559      484      -75     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza Danipiza changed the title [#25501] Fix fastddsspy tests failing on Windows due to Fast-DDS-Pro banner [#25501] Stabilize flaky Fast DDS Spy Windows application tests in CI Jul 9, 2026
…s CI

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
… tests

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza

Danipiza commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Closing PR, reopening in #154 with a different branch name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant