Skip to content

[18273] Refactor enum EntityKind::DOMAIN with EntityKind::DOMAIN_ENTITY#195

Open
Mario-DL wants to merge 1 commit into
mainfrom
hotfix/mac_redefinition_conflict
Open

[18273] Refactor enum EntityKind::DOMAIN with EntityKind::DOMAIN_ENTITY#195
Mario-DL wants to merge 1 commit into
mainfrom
hotfix/mac_redefinition_conflict

Conversation

@Mario-DL

Copy link
Copy Markdown
Contributor

In order to avoid a compilation issue with clang #184 a refactor of EntityKind::DOMAIN with EntityKind::DOMAIN_ENTITY.
This implies an API Break.

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Mario-DL temporarily deployed to codecov April 26, 2023 07:16 — with GitHub Actions Inactive
@codecov

codecov Bot commented Apr 26, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.46%. Comparing base (73a70d3) to head (98d7de9).
⚠️ Report is 100 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   58.46%   58.46%           
=======================================
  Files          38       38           
  Lines        4485     4485           
  Branches     2383     2383           
=======================================
  Hits         2622     2622           
  Misses         55       55           
  Partials     1808     1808           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@srmainwaring

srmainwaring commented Jul 10, 2023

Copy link
Copy Markdown

Also checked on macOS Ventura 13.4, Xcode 14.3.1.

Issue is legacy BSD extensions to the C standard defined in MacOSX.sdk/usr/include/math.h.

If Fast-DDS-monitor is similarly patched the monitor builds and runs on macOS (good to have!).

Could this change please be merged, it's a pre-requisite for:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants