Refs #21082. Fix release order in WriterHistory destructor.

MiguelCompany · MiguelCompany · commit 40b6dcea265a · 2024-06-26T11:50:48.000+02:00
Signed-off-by: Miguel Company &lt;miguelcompany@eprosima.com&gt;
diff --git a/src/cpp/rtps/history/WriterHistory.cpp b/src/cpp/rtps/history/WriterHistory.cpp
@@ -113,7 +113,11 @@ WriterHistory::WriterHistory(
 
 WriterHistory::~WriterHistory()
 {
-    // TODO Auto-generated destructor stub
+    // As releasing the change pool will delete the cache changes it owns,
+    // the payload pool may be called to release their payloads, so we should
+    // ensure that the payload pool is destroyed after the change pool.
+    change_pool_.reset();
+    payload_pool_.reset();
 }
 
 const std::shared_ptr<IPayloadPool>& WriterHistory::get_payload_pool() const

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,11 @@ WriterHistory::WriterHistory(`
`113`	`113`
`114`	`114`	`WriterHistory::~WriterHistory()`
`115`	`115`	`{`
`116`		`- // TODO Auto-generated destructor stub`
	`116`	`+ // As releasing the change pool will delete the cache changes it owns,`
	`117`	`+ // the payload pool may be called to release their payloads, so we should`
	`118`	`+ // ensure that the payload pool is destroyed after the change pool.`
	`119`	`+ change_pool_.reset();`
	`120`	`+ payload_pool_.reset();`
`117`	`121`	`}`
`118`	`122`
`119`	`123`	`const std::shared_ptr<IPayloadPool>& WriterHistory::get_payload_pool() const`