Review - Apply suggestions

Signed-off-by: tempate <danieldiaz@eprosima.com>

Author: tempate

src/cpp/fastdds/xtypes/serializers/idl/dynamic_type_idl.hpp

@@ -224,20 +224,22 @@ ReturnCode_t node_to_idl(
 ///////////////////////
 
 /**
- * @brief Gathers the \c element_type of the DynamicType.
+ * @brief Gathers the \c element_type of the @ref DynamicType.
  *
- * @param dyn_type The DynamicType to gather the members from.
+ * @param dyn_type The DynamicType to gather the \c element_type from.
  * @param element_type The element type of the DynamicType's \c type_descriptor.
  */
 ReturnCode_t get_element_type(
         const DynamicType::_ref_type& dyn_type,
         DynamicType::_ref_type& element_type) noexcept;
 
 /**
- * @brief Gathers the \c bounds of the DynamicType.
+ * @brief Gathers the \c bounds of the @ref DynamicType.
  *
- * @param dyn_type The DynamicType to gather the members from.
- * @param bounds The vector to store the bounds in.
+ * If there is a single bound of LENGTH_UNLIMITED, the bounds will be empty.
+ *
+ * @param dyn_type The DynamicType to gather the \c bounds from.
+ * @param bounds The bounds of the DynamicType's \c type_descriptor.
  */
 ReturnCode_t get_bounds(
         const DynamicType::_ref_type& dyn_type,

src/cpp/fastdds/xtypes/utils.cpp

@@ -36,17 +36,30 @@ ReturnCode_t idl_serialize(
         const DynamicType::_ref_type& dynamic_type,
         std::ostream& output) noexcept
 {
+    ReturnCode_t ret = RETCODE_OK;
+
     // Create a tree representation of the dynamic type
     utilities::collections::TreeNode<TreeNodeType> parent_type;
-    const auto ret = dyn_type_to_tree(dynamic_type, "PARENT", parent_type);
+    ret = dyn_type_to_tree(dynamic_type, "PARENT", parent_type);
 
     if (ret != RETCODE_OK)
     {
+        EPROSIMA_LOG_WARNING(XTYPES_UTILS,
+                "Failed to convert DynamicType to tree.");
         return ret;
     }
 
     // Serialize the tree to IDL
-    return dyn_type_tree_to_idl(parent_type, output);
+    ret = dyn_type_tree_to_idl(parent_type, output);
+
+    if (ret != RETCODE_OK)
+    {
+        EPROSIMA_LOG_WARNING(XTYPES_UTILS,
+                "Failed to convert DynamicType tree to IDL.");
+        return ret;
+    }
+
+    return RETCODE_OK;
 }
 
 ReturnCode_t json_serialize(

test/unittest/dds/xtypes/serializers/idl/DynTypeIDLTests.cpp

@@ -110,8 +110,6 @@ TEST_P(DynTypeIDLTests, to_idl)
     std::stringstream idl_serialization;
     ASSERT_EQ(idl_serialize(dyn_type, idl_serialization), RETCODE_OK);
 
-    std::cout << idl_serialization.str() << std::endl;
-
     // Compare IDLs
     ASSERT_EQ(idl_file, idl_serialization.str());
 }

test/unittest/dds/xtypes/serializers/idl/types/union_struct/gen/union_struct.hpp

@@ -318,7 +318,7 @@ class BasicUnion
             int64_t _second)
     {
         second_() = _second;
-        m__d = 2;
+        m__d = 32767;
     }
 
     /*!
@@ -392,7 +392,7 @@ class BasicUnion
             }
 
 
-    int16_t m__d {2};
+    int16_t m__d {32767};
 
     union
     {
@@ -657,7 +657,7 @@ class ComplexUnion
             const BasicUnion& _fourth)
     {
         fourth_() = _fourth;
-        m__d = 2;
+        m__d = 2147483647;
     }
 
     /*!
@@ -668,7 +668,7 @@ class ComplexUnion
             BasicUnion&& _fourth)
     {
         fourth_() = _fourth;
-        m__d = 2;
+        m__d = 2147483647;
     }
 
     /*!
@@ -742,7 +742,7 @@ class ComplexUnion
             }
 
 
-    int32_t m__d {2};
+    int32_t m__d {2147483647};
 
     union
     {

utils/scripts/update_generated_code_from_idl.sh

@@ -45,6 +45,19 @@ files_needing_output_dir=(
     './thirdparty/dds-types-test/IDL/strings.idl|../../../test/dds-types-test'
     './thirdparty/dds-types-test/IDL/structures.idl|../../../test/dds-types-test'
     './thirdparty/dds-types-test/IDL/unions.idl|../../../test/dds-types-test'
+    './test/unittest/dds/xtypes/serializers/idl/types/alias_struct/alias_struct.idl|./gen'
+    './test/unittest/dds/xtypes/serializers/idl/types/array_struct/array_struct.idl|./gen'
+    './test/unittest/dds/xtypes/serializers/idl/types/bitmask_struct/bitmask_struct.idl|./gen'
+    './test/unittest/dds/xtypes/serializers/idl/types/bitset_struct/bitset_struct.idl|./gen'
+    './test/unittest/dds/xtypes/serializers/idl/types/enum_struct/enum_struct.idl|./gen'
+    './test/unittest/dds/xtypes/serializers/idl/types/extensibility_struct/extensibility_struct.idl|./gen'
+    './test/unittest/dds/xtypes/serializers/idl/types/key_struct/key_struct.idl|./gen'
+    './test/unittest/dds/xtypes/serializers/idl/types/map_struct/map_struct.idl|./gen'
+    './test/unittest/dds/xtypes/serializers/idl/types/primitives_struct/primitives_struct.idl|./gen'
+    './test/unittest/dds/xtypes/serializers/idl/types/sequence_struct/sequence_struct.idl|./gen'
+    './test/unittest/dds/xtypes/serializers/idl/types/string_struct/string_struct.idl|./gen'
+    './test/unittest/dds/xtypes/serializers/idl/types/struct_struct/struct_struct.idl|./gen'
+    './test/unittest/dds/xtypes/serializers/idl/types/union_struct/union_struct.idl|./gen'
     )
 
 files_needing_no_typesupport=(