Skip to content

Commit 7cafd40

Browse files
committed
Refs #21129: Remove DiscoveryProtocol_t typedef
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
1 parent 0a903a0 commit 7cafd40

23 files changed

Lines changed: 68 additions & 68 deletions

File tree

examples/cpp/dds/DiscoveryServerExample/DiscoveryServerPublisher.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ bool HelloWorldPublisher::init(
152152

153153
// Set participant as DS CLIENT
154154
pqos.wire_protocol().builtin.discovery_config.discoveryProtocol =
155-
eprosima::fastdds::rtps::DiscoveryProtocol_t::CLIENT;
155+
eprosima::fastdds::rtps::DiscoveryProtocol::CLIENT;
156156

157157
// Set SERVER's GUID prefix
158158
RemoteServerAttributes remote_server_att;

examples/cpp/dds/DiscoveryServerExample/DiscoveryServerServer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ bool DiscoveryServer::init(
179179

180180
// Set participant as SERVER
181181
pqos.wire_protocol().builtin.discovery_config.discoveryProtocol =
182-
eprosima::fastdds::rtps::DiscoveryProtocol_t::SERVER;
182+
eprosima::fastdds::rtps::DiscoveryProtocol::SERVER;
183183

184184
// Set SERVER's GUID prefix
185185
pqos.wire_protocol().prefix = get_discovery_server_guid_from_id(server_id);

examples/cpp/dds/DiscoveryServerExample/DiscoveryServerSubscriber.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ bool HelloWorldSubscriber::init(
155155

156156
// Set participant as DS CLIENT
157157
pqos.wire_protocol().builtin.discovery_config.discoveryProtocol =
158-
eprosima::fastdds::rtps::DiscoveryProtocol_t::CLIENT;
158+
eprosima::fastdds::rtps::DiscoveryProtocol::CLIENT;
159159

160160
// Set SERVER's GUID prefix
161161
RemoteServerAttributes remote_server_att;

examples/cpp/dds/HelloWorldExampleSharedMem/HelloWorldPublisher.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ bool HelloWorldPublisher::init()
4646

4747
//CREATE THE PARTICIPANT
4848
DomainParticipantQos pqos;
49-
pqos.wire_protocol().builtin.discovery_config.discoveryProtocol = DiscoveryProtocol_t::SIMPLE;
49+
pqos.wire_protocol().builtin.discovery_config.discoveryProtocol = DiscoveryProtocol::SIMPLE;
5050
pqos.wire_protocol().builtin.discovery_config.use_SIMPLE_EndpointDiscoveryProtocol = true;
5151
pqos.wire_protocol().builtin.discovery_config.m_simpleEDP.use_PublicationReaderANDSubscriptionWriter = true;
5252
pqos.wire_protocol().builtin.discovery_config.m_simpleEDP.use_PublicationWriterANDSubscriptionReader = true;

examples/cpp/dds/HelloWorldExampleSharedMem/HelloWorldSubscriber.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ bool HelloWorldSubscriber::init()
4545

4646
//CREATE THE PARTICIPANT
4747
DomainParticipantQos pqos;
48-
pqos.wire_protocol().builtin.discovery_config.discoveryProtocol = DiscoveryProtocol_t::SIMPLE;
48+
pqos.wire_protocol().builtin.discovery_config.discoveryProtocol = DiscoveryProtocol::SIMPLE;
4949
pqos.wire_protocol().builtin.discovery_config.use_SIMPLE_EndpointDiscoveryProtocol = true;
5050
pqos.wire_protocol().builtin.discovery_config.m_simpleEDP.use_PublicationReaderANDSubscriptionWriter = true;
5151
pqos.wire_protocol().builtin.discovery_config.m_simpleEDP.use_PublicationWriterANDSubscriptionReader = true;

examples/cpp/rtps/AsSocket/TestReaderSocket.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ bool TestReaderSocket::init(
5252
{
5353
//CREATE PARTICIPANT
5454
RTPSParticipantAttributes PParam;
55-
PParam.builtin.discovery_config.discoveryProtocol = DiscoveryProtocol_t::NONE;
55+
PParam.builtin.discovery_config.discoveryProtocol = DiscoveryProtocol::NONE;
5656
PParam.builtin.use_WriterLivelinessProtocol = false;
5757
mp_participant = RTPSDomain::createParticipant(0, PParam);
5858
if (mp_participant == nullptr)

include/fastdds/rtps/attributes/RTPSParticipantAttributes.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ namespace fastdds {
6767
namespace rtps {
6868

6969
//! PDP subclass choice
70-
typedef enum DiscoveryProtocol
70+
enum class DiscoveryProtocol
7171
{
7272
NONE,
7373
/*!<
@@ -94,7 +94,7 @@ typedef enum DiscoveryProtocol
9494
SUPER_CLIENT /*!< The participant will behave as a client concerning all internal behaviour.
9595
Remote servers will treat it as a server and will share every discovery information. */
9696

97-
} DiscoveryProtocol_t;
97+
};
9898

9999
inline std::ostream& operator <<(
100100
std::ostream& output,
@@ -236,7 +236,7 @@ class DiscoverySettings
236236
public:
237237

238238
//! Chosen discovery protocol
239-
DiscoveryProtocol_t discoveryProtocol = DiscoveryProtocol_t::SIMPLE;
239+
DiscoveryProtocol discoveryProtocol = DiscoveryProtocol::SIMPLE;
240240

241241
/**
242242
* If set to true, SimpleEDP would be used.

src/cpp/rtps/RTPSDomain.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ RTPSParticipant* RTPSDomainImpl::createParticipant(
224224
// Above constructors create the sender resources. If a given listening port cannot be allocated an iterative
225225
// mechanism will allocate another by default. Change the default listening port is unacceptable for
226226
// discovery server Participant.
227-
if ((PParam.builtin.discovery_config.discoveryProtocol == DiscoveryProtocol_t::SERVER
228-
|| PParam.builtin.discovery_config.discoveryProtocol == DiscoveryProtocol_t::BACKUP)
227+
if ((PParam.builtin.discovery_config.discoveryProtocol == DiscoveryProtocol::SERVER
228+
|| PParam.builtin.discovery_config.discoveryProtocol == DiscoveryProtocol::BACKUP)
229229
&& pimpl->did_mutation_took_place_on_meta(
230230
PParam.builtin.metatrafficMulticastLocatorList,
231231
PParam.builtin.metatrafficUnicastLocatorList))
@@ -261,7 +261,7 @@ RTPSParticipant* RTPSDomainImpl::createParticipant(
261261
}
262262

263263
// Check the environment file in case it was modified during participant creation leading to a missed callback.
264-
if ((PParam.builtin.discovery_config.discoveryProtocol != DiscoveryProtocol_t::CLIENT) &&
264+
if ((PParam.builtin.discovery_config.discoveryProtocol != DiscoveryProtocol::CLIENT) &&
265265
instance->file_watch_handle_)
266266
{
267267
pimpl->environment_file_has_changed();
@@ -543,7 +543,7 @@ RTPSParticipant* RTPSDomainImpl::clientServerEnvironmentCreationOverride(
543543
RTPSParticipantListener* listen)
544544
{
545545
// Check the specified discovery protocol: if other than simple it has priority over ros environment variable
546-
if (att.builtin.discovery_config.discoveryProtocol != DiscoveryProtocol_t::SIMPLE)
546+
if (att.builtin.discovery_config.discoveryProtocol != DiscoveryProtocol::SIMPLE)
547547
{
548548
EPROSIMA_LOG_INFO(DOMAIN, "Detected non simple discovery protocol attributes."
549549
<< " Ignoring auto default client-server setup.");
@@ -653,13 +653,13 @@ RTPSParticipant* RTPSDomainImpl::clientServerEnvironmentCreationOverride(
653653
<< "Trying to create client with the default server setup: "
654654
<< client_att.builtin.discovery_config.m_DiscoveryServers);
655655

656-
client_att.builtin.discovery_config.discoveryProtocol = DiscoveryProtocol_t::CLIENT;
656+
client_att.builtin.discovery_config.discoveryProtocol = DiscoveryProtocol::CLIENT;
657657
// RemoteServerAttributes already fill in above
658658

659659
// Check if the client must become a super client
660660
if (ros_super_client_env())
661661
{
662-
client_att.builtin.discovery_config.discoveryProtocol = DiscoveryProtocol_t::SUPER_CLIENT;
662+
client_att.builtin.discovery_config.discoveryProtocol = DiscoveryProtocol::SUPER_CLIENT;
663663
}
664664

665665
RTPSParticipant* part = createParticipant(domain_id, enabled, client_att, listen);

src/cpp/rtps/builtin/BuiltinProtocols.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -87,38 +87,38 @@ bool BuiltinProtocols::initBuiltinProtocols(
8787
// PDP
8888
switch (m_att.discovery_config.discoveryProtocol)
8989
{
90-
case DiscoveryProtocol_t::NONE:
90+
case DiscoveryProtocol::NONE:
9191
EPROSIMA_LOG_WARNING(RTPS_PDP, "No participant discovery protocol specified");
9292
return true;
9393

94-
case DiscoveryProtocol_t::SIMPLE:
94+
case DiscoveryProtocol::SIMPLE:
9595
mp_PDP = new PDPSimple(this, allocation);
9696
break;
9797

98-
case DiscoveryProtocol_t::EXTERNAL:
98+
case DiscoveryProtocol::EXTERNAL:
9999
EPROSIMA_LOG_ERROR(RTPS_PDP, "Flag only present for debugging purposes");
100100
return false;
101101

102-
case DiscoveryProtocol_t::CLIENT:
102+
case DiscoveryProtocol::CLIENT:
103103
mp_PDP = new fastdds::rtps::PDPClient(this, allocation);
104104
break;
105105

106-
case DiscoveryProtocol_t::SERVER:
106+
case DiscoveryProtocol::SERVER:
107107
mp_PDP = new fastdds::rtps::PDPServer(this, allocation, DurabilityKind_t::TRANSIENT_LOCAL);
108108
break;
109109

110110
#if HAVE_SQLITE3
111-
case DiscoveryProtocol_t::BACKUP:
111+
case DiscoveryProtocol::BACKUP:
112112
mp_PDP = new fastdds::rtps::PDPServer(this, allocation, DurabilityKind_t::TRANSIENT);
113113
break;
114114
#endif // if HAVE_SQLITE3
115115

116-
case DiscoveryProtocol_t::SUPER_CLIENT:
116+
case DiscoveryProtocol::SUPER_CLIENT:
117117
mp_PDP = new fastdds::rtps::PDPClient(this, allocation, true);
118118
break;
119119

120120
default:
121-
EPROSIMA_LOG_ERROR(RTPS_PDP, "Unknown DiscoveryProtocol_t specified.");
121+
EPROSIMA_LOG_ERROR(RTPS_PDP, "Unknown DiscoveryProtocol specified.");
122122
return false;
123123
}
124124

@@ -314,7 +314,7 @@ void BuiltinProtocols::announceRTPSParticipantState()
314314
{
315315
mp_PDP->announceParticipantState(false);
316316
}
317-
else if (m_att.discovery_config.discoveryProtocol != DiscoveryProtocol_t::NONE)
317+
else if (m_att.discovery_config.discoveryProtocol != DiscoveryProtocol::NONE)
318318
{
319319
EPROSIMA_LOG_ERROR(RTPS_EDP, "Trying to use BuiltinProtocols interfaces before initBuiltinProtocols call");
320320
}
@@ -329,7 +329,7 @@ void BuiltinProtocols::stopRTPSParticipantAnnouncement()
329329
{
330330
mp_PDP->stopParticipantAnnouncement();
331331
}
332-
else if (m_att.discovery_config.discoveryProtocol != DiscoveryProtocol_t::NONE)
332+
else if (m_att.discovery_config.discoveryProtocol != DiscoveryProtocol::NONE)
333333
{
334334
EPROSIMA_LOG_ERROR(RTPS_EDP, "Trying to use BuiltinProtocols interfaces before initBuiltinProtocols call");
335335
}
@@ -343,7 +343,7 @@ void BuiltinProtocols::resetRTPSParticipantAnnouncement()
343343
{
344344
mp_PDP->resetParticipantAnnouncement();
345345
}
346-
else if (m_att.discovery_config.discoveryProtocol != DiscoveryProtocol_t::NONE)
346+
else if (m_att.discovery_config.discoveryProtocol != DiscoveryProtocol::NONE)
347347
{
348348
EPROSIMA_LOG_ERROR(RTPS_EDP, "Trying to use BuiltinProtocols interfaces before initBuiltinProtocols call");
349349
}

src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,10 @@ void PDPClient::initializeParticipantProxyData(
107107

108108
if (
109109
getRTPSParticipant()->getAttributes().builtin.discovery_config.discoveryProtocol
110-
!= DiscoveryProtocol_t::CLIENT
110+
!= DiscoveryProtocol::CLIENT
111111
&&
112112
getRTPSParticipant()->getAttributes().builtin.discovery_config.discoveryProtocol
113-
!= DiscoveryProtocol_t::SUPER_CLIENT )
113+
!= DiscoveryProtocol::SUPER_CLIENT )
114114
{
115115
EPROSIMA_LOG_ERROR(RTPS_PDP, "Using a PDP client object with another user's settings");
116116
}

0 commit comments

Comments
 (0)