Skip to content

[20568] Remove all redundant headers from include/fastrtps - #4546

Merged
EduPonz merged 20 commits into
masterfrom
feature/remove_from_include_fastrtps
May 20, 2024
Merged

[20568] Remove all redundant headers from include/fastrtps#4546
EduPonz merged 20 commits into
masterfrom
feature/remove_from_include_fastrtps

Conversation

@EduPonz

@EduPonz EduPonz commented Mar 11, 2024 •
edited
Loading

Copy link
Copy Markdown

Description

This PR removes all redundant headers from include/fastrtps.
It makes UnitsParser private
It depends on:

Related PRs:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • ❌ Changes are ABI compatible.
  • ❌ Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR: [20568] Adjust for removing all redundant headers from include/fastrtps Fast-DDS-docs#737
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz
EduPonz force-pushed the feature/make_private_from_include_fastrtps branch from 59efb4a to 976377c Compare March 12, 2024 07:22
@EduPonz
EduPonz force-pushed the feature/remove_from_include_fastrtps branch from e1f8a0e to a3d5178 Compare March 12, 2024 07:23
@EduPonz EduPonz added this to the v3.0.0 milestone Mar 12, 2024
@EduPonz EduPonz added the temporarily-blocked PR must be merged after another one label Mar 12, 2024
elianalf
elianalf suggested changes Mar 15, 2024
View reviewed changes
Comment thread src/cpp/utils/UnitsParser.cpp Outdated
@EduPonz
EduPonz force-pushed the feature/make_private_from_include_fastrtps branch from 976377c to 325a46b Compare March 25, 2024 14:15
@EduPonz
EduPonz force-pushed the feature/remove_from_include_fastrtps branch from a3d5178 to b5fb052 Compare March 25, 2024 14:44
@elianalf

elianalf commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

@richiprosima please test_3 this

@elianalf
elianalf self-requested a review March 25, 2024 14:51
@github-actions github-actions Bot added the ci-pending PR which CI is running label Mar 25, 2024
@EduPonz
EduPonz force-pushed the feature/make_private_from_include_fastrtps branch from 4d5a107 to 4259298 Compare March 26, 2024 15:31
Base automatically changed from feature/make_private_from_include_fastrtps to 3.0.x-devel March 27, 2024 07:29
@EduPonz
EduPonz force-pushed the feature/remove_from_include_fastrtps branch 2 times, most recently from ea4c657 to 5631a56 Compare March 27, 2024 07:57
@elianalf
elianalf requested review from elianalf and removed request for elianalf March 27, 2024 07:58
@elianalf

elianalf commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

@richiprosima please test_3 this

@EduPonz EduPonz removed the temporarily-blocked PR must be merged after another one label Mar 27, 2024
@EduPonz EduPonz mentioned this pull request Mar 27, 2024
Merged
6 tasks
@EduPonz
EduPonz force-pushed the feature/remove_from_include_fastrtps branch from 3b8d786 to c5e42bb Compare March 27, 2024 09:19
@elianalf
elianalf requested review from elianalf and removed request for elianalf March 27, 2024 09:57
elianalf
elianalf previously approved these changes Mar 27, 2024
View reviewed changes
@EduPonz
EduPonz force-pushed the feature/remove_from_include_fastrtps branch from c5e42bb to 3ae8cb5 Compare March 27, 2024 15:03
@EduPonz EduPonz mentioned this pull request Mar 27, 2024
Merged
@EduPonz
EduPonz requested a review from elianalf March 27, 2024 15:05
@EduPonz

EduPonz commented Mar 28, 2024

Copy link
Copy Markdown
Author

ASan workflow run with correct DS branch here

@elianalf

elianalf commented May 16, 2024

Copy link
Copy Markdown
Contributor

LGTM with green CI

EduPonz added 20 commits May 17, 2024 11:35
@EduPonz
Refs #20568: Remove include/fastrtps/log
1138367 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove include/fastrtps/transport
ff43573 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/qos
16f98d6 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/rtps/attributes
6dfa458 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/rtps/builtin
6d0746a 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/rtps/common
73ad6ff 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/rtps/exceptions
12d2c31 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/rtps/flowcontrol
813f7a2 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/rtps/history
530f96a 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/rtps/messages
e44be77 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/rtps/network
121ecd9 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/rtps/participant
94ba11f 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/rtps/reader
f8ab0e7 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/rtps/resources
1b6beea 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/rtps/security
0ebeca4 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/rtps/writer
79b14d9 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps/rtps
f267372 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Make UnitsParser private
91aaf08 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Remove all possible from include/fastrtps
215844e 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20568: Apply Eliana's suggestions
e4721aa 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
EduPonz force-pushed the feature/remove_from_include_fastrtps branch from 1452b8f to e4721aa Compare May 17, 2024 09:46
@EduPonz
EduPonz requested a review from elianalf May 17, 2024 09:46
@EduPonz EduPonz mentioned this pull request May 17, 2024
Merged
6 tasks
@elianalf

elianalf commented May 20, 2024

Copy link
Copy Markdown
Contributor

@richiprosima please test_3 this

@EduPonz
EduPonz merged commit 1d5fafd into master May 20, 2024
@EduPonz
EduPonz deleted the feature/remove_from_include_fastrtps branch May 20, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@elianalf elianalf elianalf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@EduPonz @elianalf