[20739] Refactor IStatusQueryable and make monitor service interfaces private by Mario-DL · Pull Request #4651 · eProsima/Fast-DDS

Mario-DL · 2024-04-04T08:26:01Z

Description

This PR brings to master the work from #4640 commit a2f4664 and 7a0c328. It refactors the IStatusQueryable() interface and make monitor service interfaces private (except from IProxyQueryable.hpp as PDP.h is still public in master and implements it).

@Mergifyio backport 2.13.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Related documentation PR: [20739] Remove ddsentitystatus from docs Fast-DDS-docs#745
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

…eryable) Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

JLBuenoLopez

Two nitpicks

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL · 2024-04-04T13:11:41Z

@richiprosima please test this

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL · 2024-04-05T10:07:21Z

@richiprosima please test this

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

JLBuenoLopez

LGTM

Mario-DL · 2024-04-09T13:59:13Z

@richiprosima please test this

EduPonz

@Mario-DL please address documentation build failure

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

EduPonz

LGTM with green CI

EduPonz · 2024-04-17T04:56:50Z

I'm seeing the same Github Windows errors in nightlies and other PR and seem to have something to do with the runners infra, so I'm merging this one.

EduPonz · 2024-04-17T04:57:54Z

@Mergifyio backport 2.13.x

mergify · 2024-04-17T04:58:00Z

backport 2.13.x

✅ Backports have been created

Details

#4687 [20739] Refactor IStatusQueryable and make monitor service interfaces private (backport #4651) has been created for branch 2.13.x but encountered conflicts

…#4651) * Refs #20739: Make monitor service interfaces private (except IProxyQueryable) Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Replace tabs with spaces in monitorservice_types.idl Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Refactor include and src files Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Refactor tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Apply suggestion regarding asserts Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs 20739: Rev 2 changes Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs 20739: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs 20739: Rev 3 changes Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Remove status assert Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Comment typo Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit fb841b9) # Conflicts: # include/fastdds/rtps/reader/RTPSReader.h # include/fastdds/rtps/writer/RTPSWriter.h

…#4651) (#4687) * Refactor IStatusQueryable and make monitor service interfaces private (#4651) * Refs #20739: Make monitor service interfaces private (except IProxyQueryable) Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Replace tabs with spaces in monitorservice_types.idl Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Refactor include and src files Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Refactor tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Apply suggestion regarding asserts Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs 20739: Rev 2 changes Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs 20739: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs 20739: Rev 3 changes Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Remove status assert Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Comment typo Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit fb841b9) # Conflicts: # include/fastdds/rtps/reader/RTPSReader.h # include/fastdds/rtps/writer/RTPSWriter.h * Fix conflicts based on original PR Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Mario-DL added 4 commits April 4, 2024 10:16

Refs #20739: Make monitor service interfaces private (except IProxyQu…

ae5d33e

…eryable) Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20739: Replace tabs with spaces in monitorservice_types.idl

d493ab0

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20739: Refactor include and src files

33ce4ba

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20739: Refactor tests

fd4005b

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL added this to the v2.14.1 milestone Apr 4, 2024

Mario-DL requested a review from JLBuenoLopez April 4, 2024 08:27

github-actions Bot added the ci-pending PR which CI is running label Apr 4, 2024

Mario-DL requested a review from richiware April 4, 2024 08:33

Refs #20739: Apply suggestion regarding asserts

e21ae54

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL mentioned this pull request Apr 4, 2024

[20703] Add missing total_count_change deadline missed status to monitor service types #4641

Closed

12 tasks

JLBuenoLopez suggested changes Apr 4, 2024

View reviewed changes

Comment thread src/cpp/fastdds/subscriber/SubscriberImpl.hpp Outdated

Comment thread src/cpp/statistics/rtps/monitor-service/MonitorService.cpp

Refs 20739: Rev 2 changes

a81affa

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL requested a review from JLBuenoLopez April 4, 2024 13:11

Refs 20739: Linter

97abb94

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

JLBuenoLopez suggested changes Apr 5, 2024

View reviewed changes

Comment thread src/cpp/fastdds/subscriber/SubscriberImpl.hpp Outdated

Comment thread src/cpp/statistics/rtps/monitor-service/MonitorService.cpp Outdated

Comment thread src/cpp/statistics/rtps/monitor-service/MonitorService.cpp

Refs 20739: Rev 3 changes

82a8b06

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL requested a review from JLBuenoLopez April 5, 2024 10:06

Refs #20739: Remove status assert

2b3b3f7

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL requested review from JLBuenoLopez and removed request for JLBuenoLopez April 9, 2024 05:39

JLBuenoLopez previously approved these changes Apr 9, 2024

View reviewed changes

EduPonz suggested changes Apr 16, 2024

View reviewed changes

Refs #20739: Comment typo

a560343

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL dismissed JLBuenoLopez’s stale review via a560343 April 16, 2024 09:12

Mario-DL requested a review from EduPonz April 16, 2024 09:13

Mario-DL mentioned this pull request Apr 16, 2024

[20739] Remove ddsentitystatus from docs eProsima/Fast-DDS-docs#745

Merged

8 tasks

EduPonz approved these changes Apr 16, 2024

View reviewed changes

EduPonz merged commit fb841b9 into master Apr 17, 2024

EduPonz deleted the fix/20739 branch April 17, 2024 04:57

This was referenced Apr 17, 2024

[20739] Refactor IStatusQueryable and make monitor service interfaces private (backport #4651) #4687

Merged

[20739] Remove ddsentitystatus from docs (backport #745) eProsima/Fast-DDS-docs#748

Merged

Uh oh!

Conversation

Mario-DL commented Apr 4, 2024 • edited by EduPonz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

JLBuenoLopez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Mario-DL commented Apr 4, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mario-DL commented Apr 5, 2024

Uh oh!

JLBuenoLopez left a comment

Choose a reason for hiding this comment

Uh oh!

Mario-DL commented Apr 9, 2024

Uh oh!

EduPonz left a comment

Choose a reason for hiding this comment

Uh oh!

EduPonz left a comment

Choose a reason for hiding this comment

Uh oh!

EduPonz commented Apr 17, 2024

Uh oh!

EduPonz commented Apr 17, 2024

Uh oh!

mergify Bot commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mario-DL commented Apr 4, 2024 •

edited by EduPonz

Loading

mergify Bot commented Apr 17, 2024 •

edited

Loading