Skip to content

[20765] Make RTPS reader implementations private - #4674

Merged
MiguelCompany merged 6 commits into
masterfrom
feature/make_rtps_reader_impl_private
May 27, 2024
Merged

[20765] Make RTPS reader implementations private#4674
MiguelCompany merged 6 commits into
masterfrom
feature/make_rtps_reader_impl_private

Conversation

@elianalf

@elianalf elianalf commented Apr 9, 2024 •
edited by MiguelCompany
Loading

Copy link
Copy Markdown
Contributor

Description

This PR makes RTPS reader implementations private:

  • StatefulPersistentReader
  • StatefulReader
  • StatelessPersistentReader
  • StatelessReader

Related PR in Fast DDS Python:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are ABI compatible.
  • ❌ Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone Apr 9, 2024
@elianalf elianalf added the needs-review PR that is ready to be reviewed label Apr 9, 2024
@elianalf elianalf mentioned this pull request Apr 11, 2024
Merged
6 tasks
@EduPonz
EduPonz force-pushed the 3.0.x-devel branch 3 times, most recently from 5148f5d to bd83bb2 Compare April 23, 2024 05:52
@EduPonz
EduPonz force-pushed the 3.0.x-devel branch 2 times, most recently from 08ee62b to 623db82 Compare May 13, 2024 09:26
@EduPonz
EduPonz deleted the branch master May 14, 2024 07:22
@EduPonz EduPonz closed this May 14, 2024
@EduPonz EduPonz reopened this May 14, 2024
@EduPonz
EduPonz changed the base branch from 3.0.x-devel to master May 14, 2024 07:28
@elianalf
elianalf force-pushed the feature/make_rtps_reader_impl_private branch from f23b852 to 3bbc297 Compare May 14, 2024 13:38
@elianalf
elianalf requested a review from EduPonz May 14, 2024 13:39
@github-actions github-actions Bot added ci-pending PR which CI is running labels May 14, 2024
@MiguelCompany

MiguelCompany commented May 24, 2024

Copy link
Copy Markdown
Member

@elianalf There are conflicts here, so a rebase is necessary.

@MiguelCompany MiguelCompany added needs rebase and removed ci-pending PR which CI is running labels May 24, 2024
elianalf added 2 commits May 24, 2024 11:04
@elianalf
Refs #20765: Make StatefulPersistentReader private
e3c6f58 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20765: Make StatelessPersistentReader private
1aebe38 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
MiguelCompany
MiguelCompany requested changes May 24, 2024
View reviewed changes

@MiguelCompany MiguelCompany left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to also change the extension of the moved headers from .h to `.hpp

Comment thread src/cpp/rtps/reader/StatefulReader.h Outdated
elianalf added 2 commits May 24, 2024 11:09
@elianalf
Refs #20765: Make StatefulReader private
b578bbe 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20765: Make StatelessReader private
fc47457 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
elianalf force-pushed the feature/make_rtps_reader_impl_private branch from 3bbc297 to fc47457 Compare May 24, 2024 09:14
@elianalf
Refs #20765: Make .h files .hpp
f47830e 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
elianalf force-pushed the feature/make_rtps_reader_impl_private branch from 01662e8 to f47830e Compare May 24, 2024 09:56
@elianalf
elianalf requested a review from MiguelCompany May 24, 2024 09:59
@elianalf elianalf removed needs-review PR that is ready to be reviewed needs rebase labels May 24, 2024
@github-actions github-actions Bot added the ci-pending PR which CI is running label May 24, 2024
MiguelCompany
MiguelCompany requested changes May 24, 2024
View reviewed changes
Comment thread src/cpp/rtps/builtin/discovery/participant/PDPSimple.cpp
Comment thread src/cpp/rtps/participant/RTPSParticipantImpl.cpp
Comment thread src/cpp/rtps/reader/StatefulPersistentReader.hpp Outdated
Comment thread src/cpp/rtps/reader/StatefulReader.hpp Outdated
Comment thread src/cpp/rtps/reader/StatelessPersistentReader.hpp Outdated
Comment thread src/cpp/rtps/reader/StatelessReader.hpp
@elianalf
Refs #20765: Apply suggestions
5c03969 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@MiguelCompany
MiguelCompany self-requested a review May 27, 2024 06:47
@elianalf

elianalf commented May 27, 2024

Copy link
Copy Markdown
Contributor Author

@richiprosima please test_3 this

@MiguelCompany
MiguelCompany merged commit 0023800 into master May 27, 2024
@MiguelCompany
MiguelCompany deleted the feature/make_rtps_reader_impl_private branch May 27, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EduPonz EduPonz Awaiting requested review from EduPonz
@MiguelCompany MiguelCompany Awaiting requested review from MiguelCompany

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@elianalf @MiguelCompany @EduPonz