[20739] Refactor IStatusQueryable and make monitor service interfaces private (backport #4651) - #4687
Merged
Merged
Conversation
…#4651) * Refs #20739: Make monitor service interfaces private (except IProxyQueryable) Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Replace tabs with spaces in monitorservice_types.idl Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Refactor include and src files Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Refactor tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Apply suggestion regarding asserts Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs 20739: Rev 2 changes Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs 20739: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs 20739: Rev 3 changes Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Remove status assert Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20739: Comment typo Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit fb841b9) # Conflicts: # include/fastdds/rtps/reader/RTPSReader.h # include/fastdds/rtps/writer/RTPSWriter.h
Contributor
Author
|
Cherry-pick of fb841b9 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
10 tasks
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Contributor
|
@richiprosima please test this |
JesusPoderoso
approved these changes
May 20, 2024
JesusPoderoso
left a comment
Contributor
There was a problem hiding this comment.
LGTM with green CI
8 tasks
Contributor
|
CI issues are unrelated to the PR content |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR brings to
masterthe work from #4640 commit a2f4664 and 7a0c328. It refactors theIStatusQueryable()interface and make monitor service interfaces private (except fromIProxyQueryable.hppasPDP.his still public inmasterand implements it).@Mergifyio backport 2.13.x
Contributor Checklist
versions.mdfile (if applicable).Related documentation PR: [20739] Remove ddsentitystatus from docs Fast-DDS-docs#745
Reviewer Checklist
This is an automatic backport of pull request #4651 done by [Mergify](https://mergify.com).