Skip to content

[21051] DynamicType to IDL serializer - #4787

Merged
EduPonz merged 52 commits into
masterfrom
feature/dynamic-type-idl
Jul 12, 2024
Merged

[21051] DynamicType to IDL serializer#4787
EduPonz merged 52 commits into
masterfrom
feature/dynamic-type-idl

Conversation

@juanlofer-eprosima

@juanlofer-eprosima juanlofer-eprosima commented May 14, 2024 •
edited by tempate
Loading

Copy link
Copy Markdown
Contributor

Description

This PR implements functionality to serialize a DynamicType to IDL.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    [21051] Documentation to serialize DynamicTypes to IDL Fast-DDS-docs#865
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

juanlofer-eprosima
juanlofer-eprosima commented May 14, 2024
View reviewed changes
Comment thread src/cpp/utils/collections/Tree.hpp
Comment thread include/fastdds/dds/xtypes/utils.hpp Outdated
Comment thread include/fastdds/dds/xtypes/utils.hpp Outdated
Comment thread src/cpp/fastdds/xtypes/utils.cpp Outdated
Comment thread src/cpp/fastdds/xtypes/utils.cpp Outdated
Comment thread src/cpp/fastdds/xtypes/utils.cpp Outdated
Comment thread src/cpp/fastdds/xtypes/utils.cpp Outdated
Comment thread src/cpp/fastdds/xtypes/utils.cpp Outdated
Comment thread src/cpp/fastdds/xtypes/utils.cpp Outdated
Comment thread src/cpp/fastdds/xtypes/utils.cpp Outdated
@juanlofer-eprosima juanlofer-eprosima added this to the v3.0.0 milestone May 14, 2024
@juanlofer-eprosima juanlofer-eprosima changed the title DynamicType to IDL serializer [21051] DynamicType to IDL serializer May 20, 2024
@juanlofer-eprosima

juanlofer-eprosima commented May 21, 2024

Copy link
Copy Markdown
Contributor Author

Consider extending conversions to take annotations into account.

@elianalf elianalf added needs-review PR that is ready to be reviewed to-do labels May 30, 2024
@tempate tempate mentioned this pull request Jun 4, 2024
Merged
@tempate
tempate force-pushed the feature/dynamic-type-idl branch from c807037 to 4610027 Compare June 20, 2024 06:15
@tempate

tempate commented Jun 20, 2024

Copy link
Copy Markdown
Contributor

@richiprosima please test_3 this

@tempate tempate mentioned this pull request Jun 21, 2024
Closed
7 tasks
@elianalf elianalf added ci-pending PR which CI is running and removed needs-review PR that is ready to be reviewed to-do labels Jun 24, 2024
richiware
richiware requested changes Jun 25, 2024
View reviewed changes
Comment thread test/unittest/dds/xtypes/type_conversion/types/idls/alias_struct.idl Outdated
@tempate
tempate force-pushed the feature/dynamic-type-idl branch from 1f4c42c to d71db60 Compare June 25, 2024 14:03
juanlofer-eprosima
juanlofer-eprosima commented Jul 2, 2024
View reviewed changes
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
juanlofer-eprosima
juanlofer-eprosima commented Jul 3, 2024
View reviewed changes
Comment thread include/fastdds/dds/xtypes/utils.hpp Outdated
Comment thread include/fastdds/dds/xtypes/utils.hpp Outdated
Comment thread include/fastdds/dds/xtypes/utils.hpp Outdated
Comment thread include/fastdds/dds/xtypes/utils.hpp Outdated
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.hpp Outdated
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
juanlofer-eprosima
juanlofer-eprosima commented Jul 4, 2024
View reviewed changes
Comment thread test/unittest/dds/xtypes/type_conversion/types/idls/inheritance_struct.idl Outdated
Comment thread test/unittest/dds/xtypes/type_conversion/types/all_types.hpp Outdated
Comment thread test/unittest/dds/xtypes/type_conversion/types/type_objects/alias_struct/alias_struct.hpp
Comment thread test/unittest/dds/xtypes/type_conversion/DynamicTypeSerializationTests.cpp
Comment thread test/unittest/dds/xtypes/type_conversion/types/idls/arrays_and_sequences.idl Outdated
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
juanlofer-eprosima
juanlofer-eprosima commented Jul 4, 2024
View reviewed changes
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
@tempate
tempate force-pushed the feature/dynamic-type-idl branch from d71db60 to 722ac43 Compare July 5, 2024 11:04
juanlofer-eprosima
juanlofer-eprosima commented Jul 8, 2024
View reviewed changes
Comment thread include/fastdds/dds/xtypes/utils.hpp Outdated
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
juanlofer-eprosima
juanlofer-eprosima commented Jul 8, 2024
View reviewed changes
Comment thread src/cpp/fastdds/xtypes/serializers/idl/dynamic_type_idl.cpp Outdated
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
Comment thread test/unittest/dds/xtypes/type_conversion/types/idls/inheritance_struct.idl Outdated
juanlofer-eprosima
juanlofer-eprosima commented Jul 8, 2024
View reviewed changes
Comment thread src/cpp/fastdds/xtypes/serializers/idl/dynamic_type_idl.cpp Outdated
Comment thread src/cpp/utils/collections/TreeNode.hpp Outdated
Comment thread src/cpp/fastdds/xtypes/serializers/idl/dynamic_type_idl.cpp
Comment thread test/unittest/dds/xtypes/serializers/idl/DynTypeIDLTests.cpp
Comment thread test/unittest/dds/xtypes/serializers/idl/types/all_types.hpp
Comment thread test/unittest/dds/xtypes/serializers/idl/types/all_types.hpp Outdated
Comment thread versions.md Outdated
Comment thread src/cpp/fastdds/xtypes/type_conversion/dyn_type_tree.ipp Outdated
juanlofer-eprosima
juanlofer-eprosima commented Jul 8, 2024
View reviewed changes
Comment thread src/cpp/fastdds/xtypes/serializers/idl/dynamic_type_idl.cpp
juanlofer-eprosima
juanlofer-eprosima commented Jul 8, 2024
View reviewed changes
Comment thread src/cpp/fastdds/xtypes/serializers/idl/dynamic_type_idl.cpp Outdated
Comment thread src/cpp/fastdds/xtypes/serializers/idl/dynamic_type_idl.cpp
@juanlofer-eprosima

juanlofer-eprosima commented Jul 9, 2024

Copy link
Copy Markdown
Contributor Author

Add the new IDL files to update_generated_code_from_idl.sh.

juanlofer-eprosima
juanlofer-eprosima commented Jul 9, 2024
View reviewed changes
Comment thread src/cpp/fastdds/xtypes/utils.cpp
Comment thread include/fastdds/dds/xtypes/utils.hpp Outdated
Comment thread src/cpp/fastdds/xtypes/serializers/idl/dynamic_type_idl.hpp Outdated
@juanlofer-eprosima

juanlofer-eprosima commented Jul 9, 2024

Copy link
Copy Markdown
Contributor Author

Add the new IDL files to update_generated_code_from_idl.sh.

By appending the following to files_needing_output_dir

'./test/unittest/dds/xtypes/serializers/idl/types/alias_struct/alias_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/array_struct/array_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/bitmask_struct/bitmask_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/bitset_struct/bitset_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/enum_struct/enum_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/extensibility_struct/extensibility_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/key_struct/key_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/map_struct/map_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/primitives_struct/primitives_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/sequence_struct/sequence_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/string_struct/string_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/struct_struct/struct_struct.idl|./gen'
'./test/unittest/dds/xtypes/serializers/idl/types/union_struct/union_struct.idl|./gen'

@tempate
tempate force-pushed the feature/dynamic-type-idl branch from b7cf212 to d62da31 Compare July 10, 2024 09:41
tempate
Review - Apply suggestions
890c285 
Signed-off-by: tempate <danieldiaz@eprosima.com>
@tempate
tempate force-pushed the feature/dynamic-type-idl branch from 18aff29 to 890c285 Compare July 11, 2024 07:02
@tempate
tempate requested a review from richiprosima July 11, 2024 07:04
tempate added 2 commits July 11, 2024 09:12
tempate
Review - Apply JSON suggestions
8419c84 
Signed-off-by: tempate <danieldiaz@eprosima.com>
tempate
Uncrustify
0626d71 
Signed-off-by: tempate <danieldiaz@eprosima.com>
@tempate
tempate requested review from richiprosima and removed request for richiprosima July 11, 2024 07:23
juanlofer-eprosima
juanlofer-eprosima commented Jul 11, 2024
View reviewed changes
Comment thread utils/scripts/update_generated_code_from_idl.sh Outdated
tempate
Review - Apply suggestions
1e866de 
Signed-off-by: tempate <danieldiaz@eprosima.com>
@tempate
tempate removed the request for review from richiprosima July 11, 2024 07:43
juanlofer-eprosima
juanlofer-eprosima commented Jul 11, 2024
View reviewed changes

@juanlofer-eprosima juanlofer-eprosima left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tempate
tempate requested a review from richiprosima July 11, 2024 07:44
@tempate tempate mentioned this pull request Jul 11, 2024
Merged
7 tasks
tempate
Fix - default_type_kind may be used uninitialized
d82da58 
Signed-off-by: tempate <danieldiaz@eprosima.com>
@tempate
tempate requested review from richiprosima and removed request for richiprosima July 11, 2024 08:43
tempate
tempate previously approved these changes Jul 11, 2024
View reviewed changes

@tempate tempate left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

richiware
richiware previously approved these changes Jul 11, 2024
View reviewed changes
@tempate
tempate dismissed stale reviews from richiware and themself via 568668d July 11, 2024 15:01
@tempate
tempate requested review from richiprosima and removed request for richiprosima July 11, 2024 15:02
tempate
Fix - signed/unsigned mismatch
d3842f4 
Signed-off-by: tempate <danieldiaz@eprosima.com>
@tempate
tempate force-pushed the feature/dynamic-type-idl branch from 568668d to d3842f4 Compare July 11, 2024 19:23
@tempate
tempate requested review from richiprosima and removed request for richiprosima July 11, 2024 19:24
tempate
tempate approved these changes Jul 12, 2024
View reviewed changes

@tempate tempate left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz
EduPonz merged commit bc67cf7 into master Jul 12, 2024
@EduPonz
EduPonz deleted the feature/dynamic-type-idl branch July 12, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richiware richiware richiware left review comments
@richiprosima richiprosima Awaiting requested review from richiprosima
+2 more reviewers
@EduPonz EduPonz EduPonz left review comments
@tempate tempate tempate approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@juanlofer-eprosima @tempate @richiware @EduPonz @elianalf