[21129] Migrate fastrtps namespace to fastdds - #4898
Merged
Conversation
elianalf
force-pushed
the
feature/migrate_fastrtps_namespace
branch
from
June 10, 2024 08:35
7f89bd2 to
8333472
Compare
elianalf
marked this pull request as ready for review
June 10, 2024 09:53
elianalf
force-pushed
the
feature/migrate_fastrtps_namespace
branch
from
June 10, 2024 10:31
5590928 to
19234a4
Compare
This was referenced Jun 10, 2024
This was referenced Jun 11, 2024
elianalf
force-pushed
the
feature/migrate_fastrtps_namespace
branch
from
June 12, 2024 06:32
19234a4 to
3a0ce6d
Compare
elianalf
force-pushed
the
feature/migrate_fastrtps_namespace
branch
from
June 12, 2024 09:26
3e559b4 to
0053c97
Compare
4 tasks
elianalf
force-pushed
the
feature/migrate_fastrtps_namespace
branch
3 times, most recently
from
June 14, 2024 09:43
86de509 to
a14d4b6
Compare
EduPonz
suggested changes
Jun 14, 2024
EduPonz
left a comment
There was a problem hiding this comment.
- StatisticsCommon.hpp has a
fastrtpsreference - StatisticsBase.hpp has a
fastrtpsreference - utils includes have a guard with
FASTRTPS - We can remove the
XFAIL_FASTRTPS_TESTSin xfail_tests.cmake - Remove
fastdds::from all headers in include. It is not needed - Remove
fastdds::from all src files. It is not needed almost anywhere - Almost all
using fastdds::that are notusing fastdds::rtpsare not needed anymore. Same happens withusing eprosima::fastdds::outside of the examples
EduPonz
suggested changes
Jun 14, 2024
There was a problem hiding this comment.
I'm afraid the following are not yet addressed in full:
- Remove
fastdds::from all headers in include. It is not needed - Remove
fastdds::from all src files. It is not needed almost anywhere - Almost all
using fastdds::that are not using fastdds::rtps are not needed anymore. - Same happens with
using eprosima::fastdds::outside of the examples
elianalf
force-pushed
the
feature/migrate_fastrtps_namespace
branch
from
June 17, 2024 06:56
8aa916e to
a151857
Compare
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
elianalf
force-pushed
the
feature/migrate_fastrtps_namespace
branch
from
June 17, 2024 07:01
a151857 to
4b8c06d
Compare
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
elianalf
force-pushed
the
feature/migrate_fastrtps_namespace
branch
from
June 17, 2024 07:23
4b8c06d to
28ba6ca
Compare
EduPonz
self-requested a review
June 17, 2024 09:36
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
EduPonz
approved these changes
Jun 17, 2024
|
@richiprosima please test_3 discovery-server |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates all the fastrtps namespace to fastdds. It also removes all the unnecessary nested namespace and using namespace.
Related PR:
Fast DDS Python: eProsima/Fast-DDS-python#135
Shapes Demo: eProsima/ShapesDemo#141
Fast DDS GEN: eProsima/Fast-DDS-Gen#350
Discovery Server: eProsima/Discovery-Server#87
Contributor Checklist
versions.mdfile (if applicable).Related documentation PR: [21129] Migrate fastrtps namespace Fast-DDS-docs#813
Reviewer Checklist