Skip to content

[21159] Remove include/fastrtps - #4930

Merged
EduPonz merged 8 commits into
masterfrom
feature/cleanup_include_fastrtps
Jun 19, 2024
Merged

[21159] Remove include/fastrtps#4930
EduPonz merged 8 commits into
masterfrom
feature/cleanup_include_fastrtps

Conversation

@EduPonz

@EduPonz EduPonz commented Jun 11, 2024 •
edited
Loading

Copy link
Copy Markdown

Description

This PR removes the include/fastrtps directory completely.

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v3.0.0 milestone Jun 11, 2024
@EduPonz EduPonz mentioned this pull request Jun 11, 2024
Merged
6 tasks
elianalf
elianalf suggested changes Jun 13, 2024
View reviewed changes
Comment thread include/fastdds/dds/core/policy/ParameterTypes.hpp
Comment thread src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated
Comment thread src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated
Comment thread src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated
Comment thread src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated
Comment thread src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated
Comment thread src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated
Comment thread src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated
Comment thread src/cpp/rtps/builtin/data/ReaderProxyData.cpp Outdated
Comment thread src/cpp/rtps/builtin/data/WriterProxyData.cpp Outdated
@EduPonz
EduPonz force-pushed the feature/cleanup_include_fastrtps branch 3 times, most recently from ed90eb3 to c1e5496 Compare June 17, 2024 09:13
@JesusPoderoso JesusPoderoso mentioned this pull request Jun 17, 2024
Merged
8 tasks
EduPonz added 7 commits June 18, 2024 11:19
@EduPonz
Refs #21159: Remove LibrarySettingsAttributes.h
c861a96 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21159: Remove include/fastrtps/common
14ffe1d 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21159: Remove ParameterTypes.h
40197e7 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21159: Remove QosPolicies.h
fd6df57 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21159: Move doxygen_modules.h
674f160 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21159: Apply Eliana's suggestions
848fec7 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21159: Remove installation of include/fastrtps
80463c2 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
EduPonz force-pushed the feature/cleanup_include_fastrtps branch from c1e5496 to 80463c2 Compare June 18, 2024 09:35
@EduPonz
EduPonz requested a review from elianalf June 18, 2024 09:38
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 18, 2024
@EduPonz

EduPonz commented Jun 18, 2024

Copy link
Copy Markdown
Author

@richiprosima please test_3 discovery-server

elianalf
elianalf previously approved these changes Jun 18, 2024
View reviewed changes
@EduPonz
Refs #21159: Correct CacheChange_t forward declaration
2891a39 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
EduPonz requested a review from elianalf June 18, 2024 10:34
@richiware richiware mentioned this pull request Jun 18, 2024
Merged
12 tasks
@EduPonz
EduPonz merged commit 8f4058b into master Jun 19, 2024
@EduPonz
EduPonz deleted the feature/cleanup_include_fastrtps branch June 19, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elianalf elianalf Awaiting requested review from elianalf

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@EduPonz @elianalf