Skip to content

[21128] Make all public headers .hpp - #4958

Merged
EduPonz merged 84 commits into
masterfrom
feature/21128
Jun 27, 2024
Merged

[21128] Make all public headers .hpp#4958
EduPonz merged 84 commits into
masterfrom
feature/21128

Conversation

@JesusPoderoso

@JesusPoderoso JesusPoderoso commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

Description

This PR performs the following changes in the public API:

  • Updates header guard following this structure: FOLDER_SUBFOLDER__FILENAME_HPP
  • Updates the doxygen file reference /* @file filename.hpp
  • Updates the file name filename.h -> filename.hpp
  • Updates the usages (includes) of the filename
  • One commit per header changed

This PR should be merged before (and it is on top of) the following PRs (in order):

This PR also needs an update in Fast DDS Python, Shapes Demo, Discovery Server and Fast DDS Gen, and regenerate all types:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Jun 17, 2024
@JesusPoderoso JesusPoderoso added the temporarily-blocked PR must be merged after another one label Jun 17, 2024
@EduPonz
EduPonz force-pushed the feature/cleanup_include_fastrtps branch from c1e5496 to 80463c2 Compare June 18, 2024 09:35
@JesusPoderoso
JesusPoderoso force-pushed the feature/21128 branch 2 times, most recently from 9efd44a to fe9ae69 Compare June 18, 2024 10:34
Comment thread include/fastdds/rtps/participant/RTPSParticipant.hpp Outdated
Comment thread include/fastdds/rtps/transport/TCPv4TransportDescriptor.hpp Outdated
@JesusPoderoso
JesusPoderoso force-pushed the feature/21128 branch 6 times, most recently from 57baad7 to ab6db3d Compare June 18, 2024 15:06
Base automatically changed from feature/cleanup_include_fastrtps to master June 19, 2024 08:16
@JesusPoderoso JesusPoderoso removed to-do temporarily-blocked PR must be merged after another one labels Jun 20, 2024
@JesusPoderoso
JesusPoderoso requested a review from EduPonz June 20, 2024 15:40
@JesusPoderoso
JesusPoderoso requested review from EduPonz and removed request for EduPonz June 20, 2024 15:41
@github-actions github-actions Bot added ci-pending PR which CI is running labels Jun 20, 2024
@JesusPoderoso
JesusPoderoso removed the request for review from EduPonz June 21, 2024 07:08
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…tDescriptor.hpp

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
JesusPoderoso requested a review from EduPonz June 25, 2024 13:19
@JesusPoderoso
JesusPoderoso requested review from EduPonz and removed request for EduPonz June 25, 2024 15:18
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@EduPonz
EduPonz requested review from EduPonz and removed request for EduPonz June 26, 2024 10:49
@EduPonz
EduPonz merged commit ccacad0 into master Jun 27, 2024
@EduPonz
EduPonz deleted the feature/21128 branch June 27, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running first-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants