Skip to content

[21219] Build profiling tests as alternate build in Ubuntu CI - #4989

Merged
EduPonz merged 4 commits into
2.14.xfrom
hotfix/2.14.x/profilling_tests_build
Jun 25, 2024
Merged

[21219] Build profiling tests as alternate build in Ubuntu CI #4989
EduPonz merged 4 commits into
2.14.xfrom
hotfix/2.14.x/profilling_tests_build

Conversation

@EduPonz

@EduPonz EduPonz commented Jun 24, 2024 •
edited
Loading

Copy link
Copy Markdown

Description

This PR is a combination of backporting #4986 with the addition of the CI changes introduced in #4960. It enable compilation of profiling tests in Ubuntu CI.

As it only affects the alternative builds step, no-test label is added.

@Mergifyio backport 2.13.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

EduPonz added 2 commits June 24, 2024 14:54
@EduPonz
Refs #21219: Always build profilling tests executable if CMake option…
dfc7a33 
… is set

Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21219: Build profiling tests as alternate build in Ubuntu CI
ad775fa 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz added the no-test Skip CI tests if PR marked with this label label Jun 24, 2024
@EduPonz EduPonz added this to the v2.14.3 milestone Jun 24, 2024
@EduPonz
EduPonz requested a review from JesusPoderoso June 24, 2024 13:13
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 24, 2024
JesusPoderoso

This comment was marked as outdated.

Sign in to view

@JesusPoderoso

JesusPoderoso commented Jun 24, 2024

Copy link
Copy Markdown
Contributor

@Mergifyio backport 2.13.x 2.10.x

@mergify

mergify Bot commented Jun 24, 2024

Copy link
Copy Markdown
Contributor

backport 2.13.x 2.10.x

🟠 Waiting for conditions to match

Details
  • merged [📌 backport requirement]

EduPonz added 2 commits June 24, 2024 16:25
@EduPonz
Refs #21219: Fix profilling tests build
a82b078 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21219: Uncrustify
e19e467 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
EduPonz requested a review from JesusPoderoso June 24, 2024 14:25
JesusPoderoso
JesusPoderoso approved these changes Jun 24, 2024
View reviewed changes

@JesusPoderoso JesusPoderoso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 25, 2024
@EduPonz

EduPonz commented Jun 25, 2024

Copy link
Copy Markdown
Author

@Mergifyio backport 2.13.x 2.10.x

@mergify

mergify Bot commented Jun 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

backport 2.13.x 2.10.x

✅ Backports have been created

Details

@EduPonz
EduPonz merged commit 2d4c6ac into 2.14.x Jun 25, 2024
@EduPonz
EduPonz deleted the hotfix/2.14.x/profilling_tests_build branch June 25, 2024 05:36
mergify Bot pushed a commit that referenced this pull request Jun 25, 2024
@EduPonz @mergify
Build profiling tests as alternate build in Ubuntu CI (#4989)
91a53b8 
* Refs #21219: Always build profilling tests executable if CMake option is set

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #21219: Build profiling tests as alternate build in Ubuntu CI

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #21219: Fix profilling tests build

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #21219: Uncrustify

Signed-off-by: eduponz <eduardoponz@eprosima.com>

---------

Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit 2d4c6ac)
mergify Bot pushed a commit that referenced this pull request Jun 25, 2024
@EduPonz @mergify
Build profiling tests as alternate build in Ubuntu CI (#4989)
208f20e 
* Refs #21219: Always build profilling tests executable if CMake option is set

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #21219: Build profiling tests as alternate build in Ubuntu CI

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #21219: Fix profilling tests build

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #21219: Uncrustify

Signed-off-by: eduponz <eduardoponz@eprosima.com>

---------

Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit 2d4c6ac)

# Conflicts:
#	test/CMakeLists.txt
This was referenced Jun 25, 2024
Merged
Merged
EduPonz added a commit that referenced this pull request Jun 25, 2024
@mergify @EduPonz
Build profiling tests as alternate build in Ubuntu CI (#4989) (#4993)
98ef5c7 
* Refs #21219: Always build profilling tests executable if CMake option is set

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #21219: Build profiling tests as alternate build in Ubuntu CI

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #21219: Fix profilling tests build

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #21219: Uncrustify

Signed-off-by: eduponz <eduardoponz@eprosima.com>

---------

Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit 2d4c6ac)

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
EduPonz added a commit that referenced this pull request Jun 26, 2024
@mergify @EduPonz @MiguelCompany
Build profiling tests as alternate build in Ubuntu CI (#4989) (#4994)
eb45141 
* Build profiling tests as alternate build in Ubuntu CI  (#4989)

* Refs #21219: Always build profilling tests executable if CMake option is set

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #21219: Build profiling tests as alternate build in Ubuntu CI

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #21219: Fix profilling tests build

Signed-off-by: eduponz <eduardoponz@eprosima.com>

* Refs #21219: Uncrustify

Signed-off-by: eduponz <eduardoponz@eprosima.com>

---------

Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit 2d4c6ac)

# Conflicts:
#	test/CMakeLists.txt

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Revert changes on type support.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

v2.14.3

Development

Successfully merging this pull request may close these issues.

2 participants

@EduPonz @JesusPoderoso