Skip to content

[21185] Examples refactor: Flow Controller - #4999

Merged
EduPonz merged 35 commits into
masterfrom
feature/example_refactor/flow_control
Jul 18, 2024
Merged

[21185] Examples refactor: Flow Controller #4999
EduPonz merged 35 commits into
masterfrom
feature/example_refactor/flow_control

Conversation

@elianalf

@elianalf elianalf commented Jun 25, 2024

Copy link
Copy Markdown
Contributor

Description

This PR is part of a suite of PR which would make a refactor in the repository examples.
It is intended to apply to most of the examples, by making them homogeneous, more understandable, and more specific to the case they were meant to be.

In this Flow Controller example, the key changes are:

  • The publishers continuously send samples. The user can set the number of samples to send.
  • The user can set the following Qos and Properties for the Flow Controller:
    • Scheduler policy used by the flow controller.
    • Maximum number of bytes to be sent to network per period.
    • Period of time in milliseconds on which the flow controller is allowed to send the maximum number of bytes per period.
    • Property fastdds.sfc.priority.
    • Property fastdds.sfc.bandwidth_reservation.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone Jun 25, 2024
@elianalf
elianalf marked this pull request as ready for review June 25, 2024 12:45
@elianalf elianalf added the needs-review PR that is ready to be reviewed label Jun 26, 2024
Comment thread examples/cpp/flow_control/.gitignore Outdated
Comment thread examples/cpp/flow_control/main.cpp Outdated
Comment thread examples/cpp/flow_control/main.cpp
Comment thread examples/cpp/flow_control/main.cpp
Comment thread examples/cpp/flow_control/main.cpp
Comment thread examples/cpp/flow_control/README.md Outdated
Comment thread examples/cpp/flow_control/README.md Outdated
Comment thread examples/cpp/flow_control/README.md Outdated
Comment thread examples/cpp/flow_control/README.md Outdated
Comment thread examples/cpp/flow_control/README.md Outdated
@elianalf elianalf removed the needs-review PR that is ready to be reviewed label Jun 27, 2024
@elianalf
elianalf force-pushed the feature/example_refactor/flow_control branch from 5af74d0 to 126a2fe Compare July 2, 2024 07:18
@elianalf
elianalf requested a review from EduPonz July 2, 2024 07:19
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jul 2, 2024
Comment thread examples/cpp/flow_control/CLIParser.hpp Outdated
Comment thread examples/cpp/flow_control/FlowControl.idl
Comment thread examples/cpp/flow_control/PublisherApp.hpp Outdated
Comment thread examples/cpp/flow_control/PublisherApp.cpp Outdated
Comment thread examples/cpp/flow_control/PublisherApp.cpp Outdated
Comment thread examples/cpp/flow_control/PublisherApp.cpp
Comment thread examples/cpp/flow_control/SubscriberApp.cpp Outdated
Comment thread examples/cpp/flow_control/PublisherApp.cpp Outdated
Comment thread examples/cpp/flow_control/SubscriberApp.cpp Outdated
Comment thread examples/cpp/flow_control/SubscriberApp.hpp Outdated
@elianalf
elianalf force-pushed the feature/example_refactor/flow_control branch from 1c2ef23 to d89d2eb Compare July 3, 2024 15:16
@elianalf
elianalf requested review from EduPonz and removed request for EduPonz July 4, 2024 08:46
@elianalf
elianalf force-pushed the feature/example_refactor/flow_control branch from 8ef6da6 to 7792d58 Compare July 4, 2024 08:57
@elianalf
elianalf requested review from EduPonz and removed request for EduPonz July 4, 2024 09:46
Comment thread examples/cpp/flow_control/CLIParser.hpp
Comment thread examples/cpp/flow_control/PublisherApp.hpp Outdated
Comment thread examples/cpp/flow_control/PublisherApp.cpp Outdated
Comment thread examples/cpp/flow_control/PublisherApp.cpp
Comment thread examples/cpp/flow_control/PublisherApp.cpp
Comment thread examples/cpp/flow_control/PublisherApp.cpp
Comment thread examples/cpp/flow_control/SubscriberApp.hpp
Comment thread examples/cpp/flow_control/SubscriberApp.cpp
Comment thread examples/cpp/flow_control/CLIParser.hpp
Comment thread examples/cpp/flow_control/SubscriberApp.cpp Outdated
Comment thread examples/cpp/flow_control/SubscriberApp.hpp
@elianalf
elianalf force-pushed the feature/example_refactor/flow_control branch from 8469835 to 48a1596 Compare July 15, 2024 10:40
@elianalf
elianalf requested a review from EduPonz July 15, 2024 10:40
@elianalf
elianalf force-pushed the feature/example_refactor/flow_control branch from 48a1596 to 1153582 Compare July 17, 2024 07:38
@elianalf
elianalf requested review from EduPonz and removed request for EduPonz July 17, 2024 07:39
@elianalf
elianalf force-pushed the feature/example_refactor/flow_control branch from 1153582 to c9a1abd Compare July 17, 2024 07:41
@elianalf
elianalf requested review from EduPonz and removed request for EduPonz July 17, 2024 07:41
elianalf added 25 commits July 18, 2024 07:29
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
…amples

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
…in xtype example

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
…f writer

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
… add index

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
elianalf force-pushed the feature/example_refactor/flow_control branch from f1f7f9e to a5f03df Compare July 18, 2024 05:30
@EduPonz
EduPonz merged commit fdc3f89 into master Jul 18, 2024
@EduPonz
EduPonz deleted the feature/example_refactor/flow_control branch July 18, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-ci Automatically pass CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants