Skip to content

[21272] Fix assertion in TopicPayloadPool::release_history - #5008

Merged
MiguelCompany merged 2 commits into
masterfrom
bugfix/21272
Jul 1, 2024
Merged

[21272] Fix assertion in TopicPayloadPool::release_history#5008
MiguelCompany merged 2 commits into
masterfrom
bugfix/21272

Conversation

@Mario-DL

@Mario-DL Mario-DL commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

Description

Bugfix to the changes introduced in #4966 in DataWriterImpl.cpp.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • NO Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • NO Any new/modified methods have been properly documented using Doxygen.
  • NO Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • NO New feature has been added to the versions.md file (if applicable).
  • NO New feature has been documented/Current behavior is correctly described in the documentation.
  • NO Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

…ALLOCATED

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v3.0.0 milestone Jun 28, 2024
@Mario-DL Mario-DL changed the title [21272] Fix the release of the history when type is plain [21272] Fix assertion in TopicPayloadPool::release_history Jun 28, 2024
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
MiguelCompany marked this pull request as ready for review July 1, 2024 06:20
@MiguelCompany
MiguelCompany self-requested a review July 1, 2024 06:20
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jul 1, 2024

@Mario-DL Mario-DL left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Double checked in Debug in local, and OK
  • Checked uncrustify in local and OK

@MiguelCompany
MiguelCompany merged commit 00b127c into master Jul 1, 2024
@MiguelCompany
MiguelCompany deleted the bugfix/21272 branch July 1, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants