Skip to content

[21711] DataWriter/Reader get_matched_publication/subscription...() Feature implementation - #5284

Merged
Mario-DL merged 10 commits into
feature/21709/mainfrom
feature/21709/feature-impl
Oct 9, 2024
Merged

[21711] DataWriter/Reader get_matched_publication/subscription...() Feature implementation#5284
Mario-DL merged 10 commits into
feature/21709/mainfrom
feature/21709/feature-impl

Conversation

@Mario-DL

@Mario-DL Mario-DL commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

Description

This PR provides the feature implementation for :

DDS

  • DataWriter::get_matched_subscriptions()
  • DataWriter::get_matched_subscription_data()
  • DataReader::get_matched_publications()
  • DataReader::get_matched_publication_data()

RTPS

  • RTPSParticipant::get_publication_info()
  • RTPSParticipant::get_subscription_info()
  • RTPSReader::matched_writers_guids()
  • RTPSWriter::matched_readers_guids()

In the 2.x series.
This PR must be merged after

Related PRs

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible. API was extended
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v2.14.4 milestone Oct 1, 2024
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima October 1, 2024 14:16
@github-actions github-actions Bot added the ci-pending PR which CI is running label Oct 1, 2024
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima October 2, 2024 05:57
@Mario-DL

Mario-DL commented Oct 2, 2024

Copy link
Copy Markdown
Contributor Author

fastdds-python-test is not prepared to take the sibling branch in the other repo as we would need to rebuild again. Will order it manually

@Mario-DL

Mario-DL commented Oct 2, 2024

Copy link
Copy Markdown
Contributor Author

@Mario-DL Mario-DL added the needs-review PR that is ready to be reviewed label Oct 2, 2024
Comment thread include/fastdds/dds/publisher/DataWriter.hpp Outdated
Comment thread src/cpp/fastdds/publisher/DataWriterImpl.cpp Outdated
Comment thread src/cpp/fastdds/subscriber/DataReaderImpl.cpp Outdated
Comment thread test/mock/rtps/RTPSReader/fastdds/rtps/reader/RTPSReader.h Outdated
@Mario-DL
Mario-DL force-pushed the feature/21709/feature-impl branch from 30515e1 to 1bf905b Compare October 7, 2024 08:35
@Mario-DL
Mario-DL requested a review from richiware October 7, 2024 08:36
@Mario-DL
Mario-DL force-pushed the feature/21709/feature-impl branch from 1bf905b to ea0a2c7 Compare October 8, 2024 07:24
@Mario-DL
Mario-DL requested review from richiware and removed request for richiware October 8, 2024 07:25
@Mario-DL
Mario-DL force-pushed the feature/21709/feature-impl branch from ea0a2c7 to ed30087 Compare October 8, 2024 08:17
@Mario-DL
Mario-DL requested review from richiware and removed request for richiware October 8, 2024 08:18
Base automatically changed from feature/21709/test-impl to feature/21709/main October 8, 2024 09:53
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…ementation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…blications() implementation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…ubscriptions() implementation

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Mario-DL force-pushed the feature/21709/feature-impl branch from ed30087 to 78d51f1 Compare October 8, 2024 09:58
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL removed the needs-review PR that is ready to be reviewed label Oct 8, 2024
@Mario-DL
Mario-DL requested review from richiware and removed request for richiware October 8, 2024 10:15
@Mario-DL
Mario-DL merged commit 065776a into feature/21709/main Oct 9, 2024
@Mario-DL
Mario-DL deleted the feature/21709/feature-impl branch October 9, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants