[23767] Fix data races on DataWriterImpl qos access (backport #6409)#6424
Open
mergify[bot] wants to merge 1 commit into
Open
[23767] Fix data races on DataWriterImpl qos access (backport #6409)#6424mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
Cherry-pick of 9a31251 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
12 tasks
Member
|
@ZakariaTalbi Would you mind fixing the conflicts here? |
ZakariaTalbi
force-pushed
the
mergify/bp/2.14.x/pr-6409
branch
from
June 10, 2026 09:46
916ad68 to
f734514
Compare
Signed-off-by: Zakaria Talbi Lalmi <zakariatalbi@eprosima.com>
ZakariaTalbi
force-pushed
the
mergify/bp/2.14.x/pr-6409
branch
from
June 10, 2026 13:48
f734514 to
d2eb0c4
Compare
ZakariaTalbi
requested review from
richiprosima
and removed request for
richiprosima
June 10, 2026 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to fix data races on
DataWriterImpl::qos_, where mainly theenable()andset_qosfunctions accessed the element simultaneously.Added a new
qos_mutex_that guardsqos_andwriter_. A concurrency regression test has also been included.@Mergifyio backport 3.2.x 2.14.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.mdfile (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #6409 done by [Mergify](https://mergify.com).