fix: interpret permission validity timestamps as UTC#6474
Open
Functionhx wants to merge 1 commit into
Open
Conversation
Functionhx
force-pushed
the
fix/permission-timestamps-utc
branch
from
July 12, 2026 04:05
5f5f297 to
b8c8df5
Compare
Functionhx
changed the title
std::mktime interprets timezone-unspecified broken-down time as local time, causing identical permission files to produce different validity periods depending on the host timezone. Use timegm on POSIX and _mkgmtime on Windows so the currently supported timezone-unspecified timestamp format is interpreted consistently as UTC. This change does not add parsing for explicit Z or +/-HH:MM timezone suffixes. Fixes eProsima#6403. Signed-off-by: Functionhx <2994114386@qq.com> Signed-off-by: Yuchen Fan <functionhx@gmail.com>
Functionhx
force-pushed
the
fix/permission-timestamps-utc
branch
from
July 12, 2026 04:25
b8c8df5 to
c378ca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::mktime interprets timezone-unspecified broken-down time as local
time, causing identical permission files to produce different validity
periods depending on the host timezone.
Use timegm on POSIX and _mkgmtime on Windows so the currently supported
timezone-unspecified timestamp format is interpreted consistently as UTC.
This change does not add parsing for explicit Z or +/-HH:MM timezone
suffixes.
Fixes #6403.