Fix Zephyr discovery IPv4 conversion - #418
Merged
EugenioCollado merged 1 commit intoJul 13, 2026
Merged
Conversation
Copy discovery IPv4 address bytes into in_addr storage so Zephyr's minimal libc does not need to provide the optional in_addr_t typedef. Add a unit test for the address conversion. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
struct in_addrstorage in both POSIX discovery backendsin_addr_ttypedef, which Zephyr's minimal libc does not provideThis addresses the
in_addr_tbuild failure reported in #397 without changing the public discovery API.Root cause
CMake classifies Zephyr as
UCLIENT_PLATFORM_POSIX, so its discovery build compiles these POSIX backends. Zephyr 2.7.1 definesstruct in_addr.s_addrasuint32_t, but its minimal libc does not definein_addr_t.Testing
ctest --output-on-failure: 15/15 tests passedin_addr_t; the new copy compiles and preserves all four address bytesgit diff --check