fix time utils overflow in windows

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

Author: EugenioCollado

cpp_utils/include/cpp_utils/time/time_utils.hpp

@@ -32,7 +32,8 @@ using Duration_ms = uint32_t;
 /**
  * Type used to represent time points
  */
-using Timestamp = std::chrono::time_point<std::chrono::system_clock>;
+using Timeclock = std::chrono::system_clock;
+using Timestamp = std::chrono::time_point<Timeclock>;
 
 /**
  * @brief Now time

cpp_utils/src/cpp/time/time_utils.cpp

@@ -36,17 +36,25 @@ namespace utils {
 
 Timestamp now() noexcept
 {
-    return std::chrono::system_clock::now();
+    return Timeclock::now();
 }
 
 Timestamp the_end_of_time() noexcept
 {
-    return std::chrono::time_point<std::chrono::system_clock>::max();
+    #if defined(_WIN32) // In Windows std::gmtime does not support negative values nor values greater than 2^32
+    return Timeclock::from_time_t(std::numeric_limits<long>::max());
+    #else
+    return Timestamp::max();
+    #endif // if defined(_WIN32)
 }
 
 Timestamp the_beginning_of_time() noexcept
 {
-    return std::chrono::time_point<std::chrono::system_clock>::min();
+    #if defined(_WIN32) // In Windows std::gmtime does not support negative values nor values greater than 2^32
+    return Timeclock::from_time_t(0);
+    #else
+    return Timestamp::min();
+    #endif // if defined(_WIN32)
 }
 
 Timestamp date_to_timestamp(
@@ -66,7 +74,7 @@ Timestamp date_to_timestamp(
     tm.tm_mon = static_cast<int>(month) - 1;
     tm.tm_year = static_cast<int>(year) - 1900;
 
-    return std::chrono::system_clock::from_time_t(timegm(&tm));
+    return Timeclock::from_time_t(timegm(&tm));
 }
 
 Timestamp time_to_timestamp(
@@ -86,7 +94,7 @@ Timestamp time_to_timestamp(
     tm.tm_min = static_cast<int>(minute);
     tm.tm_hour = static_cast<int>(hour);
 
-    return std::chrono::system_clock::from_time_t(timegm(&tm));
+    return Timeclock::from_time_t(timegm(&tm));
 }
 
 std::string timestamp_to_string(
@@ -95,8 +103,12 @@ std::string timestamp_to_string(
         bool local_time /* = false */)
 {
     std::ostringstream ss;
-    const std::chrono::high_resolution_clock::time_point::duration duration = timestamp.time_since_epoch();
-    const time_t duration_seconds = std::chrono::duration_cast<std::chrono::seconds>(duration).count();
+    time_t duration_seconds = std::chrono::duration_cast<std::chrono::seconds>(timestamp.time_since_epoch()).count();
+
+    #if defined(_WIN32) // In Windows std::gmtime does not support negative values nor values greater than 2^32
+    time_t max_value = std::numeric_limits<long>::max();
+    duration_seconds = std::max((time_t) 0, std::min(max_value, duration_seconds));
+    #endif // if defined(_WIN32)
 
     std::tm* tm = nullptr;
     if (local_time)
@@ -153,7 +165,7 @@ Timestamp string_to_timestamp(
     {
         utc_time = timegm(&tm);
     }
-    return std::chrono::system_clock::from_time_t(utc_time);
+    return Timeclock::from_time_t(utc_time);
 }
 
 std::chrono::milliseconds duration_to_ms(

cpp_utils/test/unittest/time/time_utils_test.cpp

@@ -31,8 +31,11 @@ using namespace eprosima::utils;
  * - now
  * - now with alternative format
  * - old time
+ * - the beginning of time
  * - future time
+ * - the end of time
  * - some time today
+ * - wrong date and time
  */
 TEST(time_utils_test, timestamp_to_string_to_timestamp)
 {
@@ -112,14 +115,37 @@ TEST(time_utils_test, timestamp_to_string_to_timestamp)
         ASSERT_EQ(timestamp_to_string(old_time_from_str), expected_string_os.str());
     }
 
+    // the begininng of time
+    {
+        Timestamp beginning_time = the_beginning_of_time();
+        std::string beginning_time_str = timestamp_to_string(beginning_time);
+
+        std::ostringstream expected_string_os;
+        expected_string_os
+            << 1970
+            << "-" << "01"
+            << "-" << "01"
+            << "_" << "00"
+            << "-" << "00"
+            << "-" << "00";
+
+        // Test timestamp_to_string
+        ASSERT_EQ(beginning_time_str, expected_string_os.str());
+
+        // Test string_to_timestamp
+        Timestamp beginning_time_from_str = string_to_timestamp(beginning_time_str);
+        // NOTE: cannot directly compare timestamps because some precision is lost during ts->str conversion
+        ASSERT_EQ(timestamp_to_string(beginning_time_from_str), expected_string_os.str());
+    }
+
     // future time
     {
-        Timestamp future_time = date_to_timestamp(2233u, 5u, 22u);
+        Timestamp future_time = date_to_timestamp(2033u, 5u, 22u);
         std::string future_time_str = timestamp_to_string(future_time);
 
         std::ostringstream expected_string_os;
         expected_string_os
-            << 2233
+            << 2033
             << "-" << "05"
             << "-" << 22
             << "_" << "00"
@@ -135,6 +161,29 @@ TEST(time_utils_test, timestamp_to_string_to_timestamp)
         ASSERT_EQ(timestamp_to_string(future_time_from_str), expected_string_os.str());
     }
 
+    // the end of time
+    {
+        Timestamp end_time = the_end_of_time();
+        std::string end_time_str = timestamp_to_string(end_time);
+
+        std::ostringstream expected_string_os;
+        expected_string_os
+            << 2038
+            << "-" << "01"
+            << "-" << 19
+            << "_" << "03"
+            << "-" << "14"
+            << "-" << "07";
+
+        // Test timestamp_to_string
+        ASSERT_EQ(end_time_str, expected_string_os.str());
+
+        // Test string_to_timestamp
+        Timestamp end_time_from_str = string_to_timestamp(end_time_str);
+        // NOTE: cannot directly compare timestamps because some precision is lost during ts->str conversion
+        ASSERT_EQ(timestamp_to_string(end_time_from_str), expected_string_os.str());
+    }
+
     // some time today
     {
         Timestamp some_time_today = time_to_timestamp(13u, 13u, 13u);