Eliminate rand from our lives (#57)

jparisu · web-flow · commit f6f46d49f0c9 · 2023-04-11T08:22:28.000+02:00
Signed-off-by: jparisu &lt;javierparis@eprosima.com&gt;
diff --git a/cpp_utils/src/cpp/thread_pool/task/TaskId.cpp b/cpp_utils/src/cpp/thread_pool/task/TaskId.cpp
@@ -18,7 +18,7 @@
  * This file contains class TaskId implementation.
  */
 
-#include <random>
+#include <atomic>
 
 #include <cpp_utils/thread_pool/task/TaskId.hpp>
 
@@ -27,7 +27,8 @@ namespace utils {
 
 TaskId new_unique_task_id()
 {
-    return static_cast<TaskId>(std::rand());
+    static std::atomic<TaskId> unique_task_id_{0};
+    return unique_task_id_++;
 }
 
 } /* namespace utils */

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`* This file contains class TaskId implementation.`
`19`	`19`	`*/`
`20`	`20`
`21`		`-#include <random>`
	`21`	`+#include <atomic>`
`22`	`22`
`23`	`23`	`#include <cpp_utils/thread_pool/task/TaskId.hpp>`
`24`	`24`
`@@ -27,7 +27,8 @@ namespace utils {`
`27`	`27`
`28`	`28`	`TaskId new_unique_task_id()`
`29`	`29`	`{`
`30`		`- return static_cast<TaskId>(std::rand());`
	`30`	`+ static std::atomic<TaskId> unique_task_id_{0};`
	`31`	`+ return unique_task_id_++;`
`31`	`32`	`}`
`32`	`33`
`33`	`34`	`} /* namespace utils */`