Skip to content

Fix wrong use of ret code enumeration in logs - #145

Merged
emiliocuestaf merged 2 commits into
mainfrom
bugfix/ill-return-code-operator
Jan 2, 2026
Merged

Fix wrong use of ret code enumeration in logs#145
emiliocuestaf merged 2 commits into
mainfrom
bugfix/ill-return-code-operator

Conversation

@emiliocuestaf

@emiliocuestaf emiliocuestaf commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

When using ReturnCode::operator<<, a map indexed by ReturnCode was being used. However, in the initialisation of that map keys of type ReturnCode::ReturnCodeValue were being used. Thus, the constructor of ReturnCode was being implicitly called with a non-desired and implicit casting of the passed ReturnCodeValue to fastdds::dds::ReturnCode_t. This PR fix that behaviour.

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@codecov-commenter

codecov-commenter commented Jan 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.43%. Comparing base (ecfc750) to head (e24e3ab).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cpp_utils/src/cpp/ReturnCode.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   60.59%   60.43%   -0.16%     
==========================================
  Files          65       65              
  Lines        1921     1921              
  Branches      543      543              
==========================================
- Hits         1164     1161       -3     
- Misses        437      440       +3     
  Partials      320      320              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juanlofer-eprosima juanlofer-eprosima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emiliocuestaf
emiliocuestaf merged commit f67337a into main Jan 2, 2026
15 checks passed
@emiliocuestaf
emiliocuestaf deleted the bugfix/ill-return-code-operator branch January 2, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants