refactor(api): merge POST route groups under one Swagger tag

- Addresses review feedback on #186
- Gives both POST blueprints a shared tag so the Swagger docs show a single POST group whether or not the store-backed routes are registered
- APIFlask emits one top-level tag entry per blueprint, so the shared tag would appear twice in openapi.json (OpenAPI requires unique tag names)
- Added a spec processor decorator to depulicate list.
- Added supporting test

Author: alexhambley

app/__init__.py

@@ -48,6 +48,17 @@ def create_app(settings: Settings | None = None) -> APIFlask:
     app.config["STORAGE_ENABLED"] = settings.storage_enabled
     app.config["PROFILES_PATH"] = settings.profiles_path
 
+    # APIFlask emits one top-level tag entry per blueprint, so the two POST
+    # blueprints sharing a tag would duplicate it; OpenAPI requires unique
+    # tag names.
+    @app.spec_processor
+    def dedupe_spec_tags(spec):
+        seen = set()
+        spec["tags"] = [
+            t for t in spec.get("tags", []) if not (t["name"] in seen or seen.add(t["name"]))
+        ]
+        return spec
+
     # Always available:
     app.register_blueprint(health_bp)
     app.register_blueprint(v1_post_bp, url_prefix="/v1/ro_crates")

app/ro_crates/routes/post_routes.py

@@ -10,11 +10,12 @@
 )
 
 # Always-on blueprint:
-post_routes_bp = APIBlueprint("post_routes", __name__)
+post_routes_bp = APIBlueprint("post_routes", __name__, tag="Post_Routes")
 
 # Store-backed blueprint. Only registered when storage is enabled
 # (see app.create_app), so the ID-based routes are unreachable by default.
-minio_post_routes_bp = APIBlueprint("minio_post_routes", __name__)
+# Shares the always-on blueprint's docs tag so Swagger shows one POST group.
+minio_post_routes_bp = APIBlueprint("minio_post_routes", __name__, tag="Post_Routes")
 
 
 class ValidateCrate(Schema):

tests/test_app_factory.py

@@ -81,3 +81,17 @@ def test_incoming_request_id_is_echoed():
     )
 
     assert response.headers["X-Request-ID"] == "caller-supplied-id"
+
+
+def test_openapi_groups_posts_under_one_tag_with_unique_tags():
+    """Both POST endpoints share one docs group and the spec has no duplicate tags."""
+    app = create_app(settings=Settings.from_env(_storage_env()))
+    spec = app.test_client().get("/openapi.json").json
+
+    tag_names = [tag["name"] for tag in spec["tags"]]
+    assert len(tag_names) == len(set(tag_names))
+
+    paths = spec["paths"]
+    assert paths["/v1/ro_crates/validate_metadata"]["post"]["tags"] == ["Post_Routes"]
+    assert paths["/v1/ro_crates/{crate_id}/validation"]["post"]["tags"] == ["Post_Routes"]
+    assert paths["/v1/ro_crates/{crate_id}/validation"]["get"]["tags"] == ["Get_Routes"]