add minio client to return ro-crate validation

Author: douglowe

app/tasks/validation_tasks.py

@@ -242,17 +242,19 @@ def check_validation_exists(
 
 
 def return_ro_crate_validation(
+        minio_client: object,
         bucket_name: str,
         crate_id: str,
         root_path: str,
 ) -> dict | str:
     """
     Retrieves the validation result for an RO-Crate using the provided Crate ID.
 
+    :param minio_client: The MinIO client
     :param crate_id: The ID of the RO-Crate that has been validated
     :return: The validation result
     """
 
     logging.info(f"Fetching validation result for RO-Crate {crate_id}")
 
-    return get_validation_status_from_minio(bucket_name, crate_id, root_path)
+    return get_validation_status_from_minio(minio_client, bucket_name, crate_id, root_path)

tests/test_validation_tasks.py

@@ -385,21 +385,21 @@ def test_return_validation_returns_dict(mock_get_status):
     # Simulate dict result
     mock_get_status.return_value = {"status": "passed", "errors": []}
 
-    result = return_ro_crate_validation("test_bucket", "crate123", None)
+    result = return_ro_crate_validation("minio_client", "test_bucket", "crate123", None)
     assert isinstance(result, dict)
     assert result["status"] == "passed"
-    mock_get_status.assert_called_once_with("test_bucket", "crate123", None)
+    mock_get_status.assert_called_once_with("minio_client", "test_bucket", "crate123", None)
 
 
 @mock.patch("app.tasks.validation_tasks.get_validation_status_from_minio")
 def test_return_validation_returns_string(mock_get_status):
     # Simulate string result
     mock_get_status.return_value = "Validation result: OK"
 
-    result = return_ro_crate_validation("test_bucket", "crate456", None)
+    result = return_ro_crate_validation("minio_client", "test_bucket", "crate456", None)
     assert isinstance(result, str)
     assert "OK" in result
-    mock_get_status.assert_called_once_with("test_bucket", "crate456", None)
+    mock_get_status.assert_called_once_with("minio_client", "test_bucket", "crate456", None)
 
 
 @mock.patch("app.tasks.validation_tasks.get_validation_status_from_minio")
@@ -408,10 +408,10 @@ def test_return_validation_raises_error(mock_get_status):
     mock_get_status.side_effect = InvalidAPIUsage("MinIO S3 Error: empty", 500)
 
     with pytest.raises(InvalidAPIUsage) as exc_info:
-        return_ro_crate_validation("test_bucket", "crate789", None)
+        return_ro_crate_validation("minio_client", "test_bucket", "crate789", None)
 
     assert "MinIO S3 Error" in str(exc_info.value.message)
-    mock_get_status.assert_called_once_with("test_bucket", "crate789", None)
+    mock_get_status.assert_called_once_with("minio_client", "test_bucket", "crate789", None)
 
 
 # Test function: check_ro_crate_exists