Tests for the MinIO Utils library - #59
Merged
Merged
Conversation
|
Haha that's funny I have I think the exact opposite approach to chatGPT!
I would ask it this But not this
I have no serious opinion about how they are broken up I am afraid! |
|
but I do find writing tests kinda boring but but very worthwhile |
Collaborator
Author
|
Testing does work - it reminded me I needed to include the code changes for the API that @alexhambley suggested for removing the partial JSON validation. |
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've asked ChatGPT to write some tests describing the current MinIO Utils library. These cover all the functions inside the
app.utils.minio_utilslibrary.Should I keep all the tests in a single file per library file - or should split them into seperate test files for each function we have?