Skip to content

Move minio credentials into api argument - #84

Merged
douglowe merged 14 commits into
developfrom
79-crate-validator-accepts-minio-credentials-as-api-argument
Aug 5, 2025
Merged

Move minio credentials into api argument#84
douglowe merged 14 commits into
developfrom
79-crate-validator-accepts-minio-credentials-as-api-argument

Conversation

@douglowe

@douglowe douglowe commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator

This PR does two things:

  1. MinIO credentials are now passed in the API payloads
  2. MinIO client is loaded higher up the stack, and passed to functions which need it, reducing the repetition of this activity.

douglowe added 14 commits August 4, 2025 23:07
@douglowe douglowe linked an issue Aug 5, 2025 that may be closed by this pull request
crate validator accepts minio credentials as API argument #79
Closed
@douglowe douglowe self-assigned this Aug 5, 2025
OliverWoolland
OliverWoolland approved these changes Aug 5, 2025
View reviewed changes

@OliverWoolland OliverWoolland left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks sensible to me

@douglowe
douglowe merged commit 19e7003 into develop Aug 5, 2025
2 checks passed
@douglowe
douglowe deleted the 79-crate-validator-accepts-minio-credentials-as-api-argument branch August 5, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OliverWoolland OliverWoolland OliverWoolland approved these changes
@alexhambley alexhambley Awaiting requested review from alexhambley

Assignees

@douglowe douglowe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crate validator accepts minio credentials as API argument

2 participants

@douglowe @OliverWoolland