(i) Removed minimum length requirement for name of DownloadAction. (ii) Existence of entity representing the downloaded workflow is now a MAY (before it was a SHOULD).

EttoreM · EttoreM · commit 166bd0f09dac · 2025-12-23T08:38:54.000Z
diff --git a/rocrate_validator/profiles/five-safes-crate/may/14_workflow_retrieval_phase.ttl b/rocrate_validator/profiles/five-safes-crate/may/14_workflow_retrieval_phase.ttl
@@ -23,6 +23,42 @@
 @prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
 
 
+five-safes-crate:DownloadedWorkflowSHOULDExistAndBeReferencedByDownloadActionResult
+    a sh:NodeShape ;
+    sh:name "DownloadAction" ;
+    sh:description "Validates that DownloadAction result references an existing entity" ;
+    sh:targetClass schema:DownloadAction ;
+
+    sh:property [
+        a sh:PropertyShape ;
+        sh:name "Result" ;
+        sh:description "The result property must reference an existing entity in the RO-Crate" ;
+        sh:path schema:result ;
+        sh:minCount 1 ;
+        sh:nodeKind sh:IRI ;
+
+        sh:sparql [
+            a sh:SPARQLConstraint ;
+            sh:select """
+                PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
+                PREFIX schema: <http://schema.org/>
+
+                SELECT $this $value
+                WHERE {
+                    $this schema:result $value .
+                    
+                    # Entity must have BOTH type AND name (proper definition)
+                    FILTER NOT EXISTS {
+                        $value rdf:type schema:Dataset .
+                    }
+                }
+            """ ;
+            sh:severity sh:Info ;
+            sh:message "The entity represented the downloaded workflow is not properly defined in the RO-Crate and/or it is not referenced by `DownloadAction` --> `result`." ;
+        ] ;
+    ] .
+
+
 five-safes-crate:DownloadActionMayHaveStartTimeIfBegun
     a sh:NodeShape ;
     sh:name "DownloadAction" ;
diff --git a/rocrate_validator/profiles/five-safes-crate/must/14_workflow_retrieval_phase.ttl b/rocrate_validator/profiles/five-safes-crate/must/14_workflow_retrieval_phase.ttl
@@ -32,14 +32,13 @@ five-safes-crate:DownloadActionObjectMUSTHavesDescriptiveName
     sh:property [
         a sh:PropertyShape ;
         sh:name "name" ;
-        sh:description "DownloadAction MUST have a human readable name string of at least 10 characters." ;
+        sh:description "DownloadAction MUST have a human readable name string." ;
         sh:path schema:name ;
         sh:minCount 1 ;
         sh:maxCount 1 ;
         sh:datatype xsd:string ;
-        sh:minLength 10 ;
         sh:severity sh:Violation ;
-        sh:message "DownloadAction MUST have a human readable name string of at least 10 characters." ;
+        sh:message "DownloadAction MUST have a human readable name string." ;
     ] .
 
 five-safes-crate:DownloadActionStartTimeMUSTFollowISOStandard
diff --git a/rocrate_validator/profiles/five-safes-crate/should/14_workflow_retrieval_phase.ttl b/rocrate_validator/profiles/five-safes-crate/should/14_workflow_retrieval_phase.ttl
@@ -108,42 +108,6 @@ five-safes-crate:DownloadActionShouldHaveEndTimeIfEnded
     ] .
 
 
-five-safes-crate:DownloadedWorkflowSHOULDExistAndBeReferencedByDownloadActionResult
-    a sh:NodeShape ;
-    sh:name "DownloadAction" ;
-    sh:description "Validates that DownloadAction result references an existing entity" ;
-    sh:targetClass schema:DownloadAction ;
-
-    sh:property [
-        a sh:PropertyShape ;
-        sh:name "Result" ;
-        sh:description "The result property must reference an existing entity in the RO-Crate" ;
-        sh:path schema:result ;
-        sh:minCount 1 ;
-        sh:nodeKind sh:IRI ;
-
-        sh:sparql [
-            a sh:SPARQLConstraint ;
-            sh:select """
-                PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
-                PREFIX schema: <http://schema.org/>
-
-                SELECT $this $value
-                WHERE {
-                    $this schema:result $value .
-                    
-                    # Entity must have BOTH type AND name (proper definition)
-                    FILTER NOT EXISTS {
-                        $value rdf:type schema:Dataset .
-                    }
-                }
-            """ ;
-            sh:severity sh:Warning ;
-            sh:message "The entity represented the downloaded workflow is not properly defined in the RO-Crate and/or it is not referenced by `DownloadAction` --> `result`." ;
-        ] ;
-    ] .
-
-
 five-safes-crate:DownloadActionShouldHaveActionStatus
     a sh:NodeShape ;
     sh:name "DownloadAction" ;
diff --git a/tests/integration/profiles/five-safes-crate/test_5src_14_workflow_retrieval_phase.py b/tests/integration/profiles/five-safes-crate/test_5src_14_workflow_retrieval_phase.py
@@ -45,7 +45,7 @@ def test_5src_download_action_does_not_have_name():
         expected_validation_result=False,
         expected_triggered_requirements=["DownloadAction"],
         expected_triggered_issues=[
-            "DownloadAction MUST have a human readable name string of at least 10 characters."
+            "DownloadAction MUST have a human readable name string."
         ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,
@@ -74,36 +74,7 @@ def test_5src_download_action_name_not_a_string():
         expected_validation_result=False,
         expected_triggered_requirements=["DownloadAction"],
         expected_triggered_issues=[
-            "DownloadAction MUST have a human readable name string of at least 10 characters."
-        ],
-        profile_identifier="five-safes-crate",
-        rocrate_entity_mod_sparql=sparql,
-    )
-
-
-def test_5src_download_action_name_not_long_enough():
-    sparql = (
-        SPARQL_PREFIXES
-        + """
-        DELETE {
-            ?this schema:name ?name .
-        }
-        INSERT {
-            ?this schema:name "Short" .
-        }
-        WHERE {
-            ?this rdf:type schema:DownloadAction .
-        }
-        """
-    )
-
-    do_entity_test(
-        rocrate_path=ValidROC().five_safes_crate_result,
-        requirement_severity=Severity.REQUIRED,
-        expected_validation_result=False,
-        expected_triggered_requirements=["DownloadAction"],
-        expected_triggered_issues=[
-            "DownloadAction MUST have a human readable name string of at least 10 characters."
+            "DownloadAction MUST have a human readable name string."
         ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,
@@ -361,16 +332,18 @@ def test_5src_download_action_does_not_have_end_time():
     )
 
 
-def test_5src_downloaded_workflow_is_not_represented_by_its_own_entity():
+def test_5src_downloaded_workflow_is_not_referenced_by_download_action_result():
     sparql = (
         SPARQL_PREFIXES
         + """
         DELETE {
-            ?wf ?p ?o .
+            ?s schema:result ?o .
+        }
+        INSERT {
+            ?s schema:result "This is not the downloaded workflow entity" .
         }
         WHERE {
-            ?wf ?p ?o .
-            ?da schema:result ?wf ;
+            ?s schema:result ?o ;
                rdf:type schema:DownloadAction .
         }
         """
@@ -392,19 +365,20 @@ def test_5src_downloaded_workflow_is_not_represented_by_its_own_entity():
     )
 
 
-def test_5src_downloaded_workflow_is_not_referenced_by_download_action_result():
+def test_5src_downloaded_workflow_entity_is_not_of_type_dataset():
     sparql = (
         SPARQL_PREFIXES
         + """
         DELETE {
-            ?s schema:result ?o .
+            ?wf rdf:type schema:Dataset .
         }
         INSERT {
-            ?s schema:result "This is not the downloaded workflow entity" .
+            ?wf rdf:type schema:Person .
         }
         WHERE {
-            ?s schema:result ?o ;
-               rdf:type schema:DownloadAction .
+            ?wf rdf:type schema:Dataset .
+            ?da schema:result ?wf ;
+                rdf:type schema:DownloadAction .
         }
         """
     )
@@ -425,20 +399,16 @@ def test_5src_downloaded_workflow_is_not_referenced_by_download_action_result():
     )
 
 
-def test_5src_downloaded_workflow_entity_is_not_of_type_dataset():
+def test_5src_download_action_does_not_have_action_status_property():
     sparql = (
         SPARQL_PREFIXES
         + """
         DELETE {
-            ?wf rdf:type schema:Dataset .
-        }
-        INSERT {
-            ?wf rdf:type schema:Person .
+            ?s schema:actionStatus ?o .
         }
         WHERE {
-            ?wf rdf:type schema:Dataset .
-            ?da schema:result ?wf ;
-                rdf:type schema:DownloadAction .
+            ?s rdf:type schema:DownloadAction ;
+               schema:actionStatus ?o .
         }
         """
     )
@@ -449,46 +419,47 @@ def test_5src_downloaded_workflow_entity_is_not_of_type_dataset():
         expected_validation_result=False,
         expected_triggered_requirements=["DownloadAction"],
         expected_triggered_issues=[
-            (
-                "The entity represented the downloaded workflow is not properly defined in the "
-                "RO-Crate and/or it is not referenced by `DownloadAction` --> `result`."
-            )
+            "`DownloadAction` SHOULD have `actionStatus` property."
         ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,
     )
 
 
-def test_5src_download_action_does_not_have_action_status_property():
+# ----- MAY fails tests
+
+
+def test_5src_downloaded_workflow_is_not_represented_by_its_own_entity():
     sparql = (
         SPARQL_PREFIXES
         + """
         DELETE {
-            ?s schema:actionStatus ?o .
+            ?wf ?p ?o .
         }
         WHERE {
-            ?s rdf:type schema:DownloadAction ;
-               schema:actionStatus ?o .
+            ?wf ?p ?o .
+            ?da schema:result ?wf ;
+               rdf:type schema:DownloadAction .
         }
         """
     )
 
     do_entity_test(
         rocrate_path=ValidROC().five_safes_crate_result,
-        requirement_severity=Severity.RECOMMENDED,
+        requirement_severity=Severity.OPTIONAL,
         expected_validation_result=False,
         expected_triggered_requirements=["DownloadAction"],
         expected_triggered_issues=[
-            "`DownloadAction` SHOULD have `actionStatus` property."
+            (
+                "The entity represented the downloaded workflow is not properly defined in the "
+                "RO-Crate and/or it is not referenced by `DownloadAction` --> `result`."
+            )
         ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,
     )
 
 
-# ----- MAY fails tests
-
-
 def test_5src_download_action_does_not_have_start_time():
     sparql = (
         SPARQL_PREFIXES
