fix(shacl): 🐛 drop sub-threshold pyshacl violations at the source

Skip sh:ValidationResult nodes whose check severity is below the requested
`requirement_severity` while iterating pyshacl results, so they never become
Issues. This makes every consumer of `ValidationResult._issues` consistent
with the threshold (not just `failed_requirements`/`failed_checks`) and
avoids materializing non-actionable violations.

Author: kikkomep

rocrate_validator/requirements/shacl/checks.py

@@ -282,6 +282,18 @@ def __do_execute_check__(self, shacl_context: SHACLValidationContext):
             if requirementCheck is None:
                 logger.warning("No check instance found for shape: %s", shape.key)
                 continue
+            # Drop violations whose check severity is below the requested
+            # `requirement_severity`: pyshacl still emits sh:ValidationResult
+            # nodes for sh:Warning / sh:Info, but they are not actionable at a
+            # stricter validation level.
+            if requirementCheck.severity < shacl_context.settings.requirement_severity:
+                logger.debug(
+                    "Dropping violation for check %s: severity %s below requested %s",
+                    requirementCheck.identifier,
+                    requirementCheck.severity,
+                    shacl_context.settings.requirement_severity,
+                )
+                continue
             if (
                 not shacl_context.settings.skip_checks
                 or requirementCheck.identifier not in shacl_context.settings.skip_checks