(1) Changed to , (2) Replaced with , and (3) added a test to account for the new potential failing situation introduced by point 2.

Author: EttoreM

rocrate_validator/profiles/five-safes-crate/should/5_profile_conformance.ttl

@@ -45,14 +45,13 @@ five-safes-crate:RootDatasetDatePublishedWhenPublished
     sh:description "If the root dataset is published (has schema:publisher), it SHOULD have schema:datePublished." ;
     sh:targetClass ro-crate:RootDataEntity ;
     sh:severity sh:Warning ;
-    sh:message "Published crates SHOULD include schema:datePublished." ;
-    sh:or (
-        # datePublished not required if no publisher:
+    sh:message "A crate SHOULD have a publishedDate if and only if it has a publisher." ;
+    sh:xone (
+        # datePublished SHOULD be present if and only if the publisher is specified:
         [ sh:not [ sh:property [
             sh:path schema:publisher ;
             sh:minCount 1 ;
         ]]]
-        # datePublished required if publisher present:
         [ sh:property [
             sh:path schema:datePublished ;
             sh:minCount 1 ;
@@ -63,7 +62,7 @@ five-safes-crate:RootDatasetLicenseWhenPublished
     a sh:NodeShape ;
     sh:name "License present on published crates" ;
     sh:description "If the root dataset is published (has schema:publisher), it SHOULD declare a license." ;
-    sh:targetNode ro: ;
+    sh:targetClass ro-crate:RootDataEntity ;
     sh:severity sh:Warning ;
     sh:message "Profile Conformance: Published crates SHOULD include a license." ;
     sh:or (

tests/integration/profiles/five-safes-crate/test_5src_5_profile_conformance.py

@@ -119,7 +119,39 @@ def test_5src_root_data_entity_has_publisher_but_not_date_published():
         expected_validation_result=False,
         expected_triggered_requirements=["datePublished present on published crates"],
         expected_triggered_issues=[
-            "Published crates SHOULD include schema:datePublished."
+            "A crate SHOULD have a publishedDate if and only if it has a publisher."
+        ],
+        profile_identifier="five-safes-crate",
+        rocrate_entity_mod_sparql=sparql,
+    )
+
+
+def test_5src_root_data_entity_has_date_published_but_not_publisher():
+    """
+    Test a Five Safes Crate where the RootDataEntity has published but not date published.
+    """
+    sparql = (
+        SPARQL_PREFIXES
+        + """
+        DELETE {
+            ?rootdataentity schema:datePublished ?datePublished .
+        }
+        WHERE {
+            ?metadatafile a schema:CreativeWork ;
+                          schema:about ?rootdataentity .
+            ?rootdataentity schema:publisher ?publisher ;
+                            schema:datePublished ?datePublished .
+        }
+        """
+    )
+
+    do_entity_test(
+        rocrate_path=ValidROC().five_safes_crate_result,
+        requirement_severity=Severity.RECOMMENDED,
+        expected_validation_result=False,
+        expected_triggered_requirements=["datePublished present on published crates"],
+        expected_triggered_issues=[
+            "A crate SHOULD have a publishedDate if and only if it has a publisher."
         ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,