added check for indirect path from data entities to root data entity and corresponding test

Author: floWetzels

rocrate_validator/profiles/ro-crate/must/4_data_entity_metadata.ttl

@@ -137,9 +137,12 @@ ro-crate:DataEntityRequiredPropertiesShape a sh:NodeShape ;
     sh:property
         [
             a sh:PropertyShape ;
-            sh:path [ sh:inversePath schema_org:hasPart ] ;
-            sh:node schema_org:Dataset ;
-            sh:minCount 1 ;
+            # sh:path [ sh:inversePath schema_org:hasPart ] ;
+            # sh:node schema_org:Dataset ;
+            # sh:minCount 1 ;
+            sh:path [ sh:oneOrMorePath [ sh:inversePath schema_org:hasPart ] ] ;
+            sh:qualifiedValueShape [ sh:class ro-crate:RootDataEntity ] ;
+            sh:qualifiedMinCount 1 ;
             sh:name "Data Entity MUST be directly referenced" ;
             sh:description """Check if the Data Entity is linked, either directly or indirectly, to the `Root Data Entity` using the `hasPart` (as defined in `schema.org`) property" """ ;
             # sh:message "A Data Entity MUST be directly or indirectly linked to the `Root Data Entity` through the `hasPart` property" ;

tests/integration/profiles/ro-crate/test_data_entity_metadata.py

@@ -48,6 +48,16 @@ def test_data_entity_must_be_directly_linked():
     )
 
 
+def test_data_entity_not_linked():
+    """Test a RO-Crate with datasets not linked to the root data entity."""
+    do_entity_test(
+        paths.dataset_not_linked_to_root,
+        models.Severity.REQUIRED,
+        False,
+        skip_checks=[SKIP_LOCAL_DATA_ENTITY_EXISTENCE_CHECK_IDENTIFIER]
+    )
+
+
 def test_data_entity_must_be_indirectly_linked():
     """Test a RO-Crate without a root data entity."""
     do_entity_test(

tests/ro_crates.py

@@ -242,6 +242,10 @@ def missing_hasPart_data_entity_reference(self) -> Path:
     def direct_hasPart_data_entity_reference(self) -> Path:
         return self.base_path / "valid_direct_hasPart_reference"
 
+    @property
+    def dataset_not_linked_to_root(self) -> Path:
+        return self.base_path / "cyclic_datasets"
+
     @property
     def indirect_hasPart_data_entity_reference(self) -> Path:
         return self.base_path / "valid_indirect_hasPart_reference"