Skip to content

Commit 765296a

Browse files
committed
Removed redundant tests.
1 parent 166bd0f commit 765296a

2 files changed

Lines changed: 7 additions & 70 deletions

File tree

rocrate_validator/profiles/five-safes-crate/may/14_workflow_retrieval_phase.ttl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,10 @@ five-safes-crate:DownloadedWorkflowSHOULDExistAndBeReferencedByDownloadActionRes
5454
}
5555
""" ;
5656
sh:severity sh:Info ;
57-
sh:message "The entity represented the downloaded workflow is not properly defined in the RO-Crate and/or it is not referenced by `DownloadAction` --> `result`." ;
57+
sh:message ("The entity representing the downloaded workflow is not defined, "
58+
"OR is not referenced by `DownloadAction` --> `result`, "
59+
"OR is not of type `schema:Dataset`."
60+
) ;
5861
] ;
5962
] .
6063

tests/integration/profiles/five-safes-crate/test_5src_14_workflow_retrieval_phase.py

Lines changed: 3 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -332,73 +332,6 @@ def test_5src_download_action_does_not_have_end_time():
332332
)
333333

334334

335-
def test_5src_downloaded_workflow_is_not_referenced_by_download_action_result():
336-
sparql = (
337-
SPARQL_PREFIXES
338-
+ """
339-
DELETE {
340-
?s schema:result ?o .
341-
}
342-
INSERT {
343-
?s schema:result "This is not the downloaded workflow entity" .
344-
}
345-
WHERE {
346-
?s schema:result ?o ;
347-
rdf:type schema:DownloadAction .
348-
}
349-
"""
350-
)
351-
352-
do_entity_test(
353-
rocrate_path=ValidROC().five_safes_crate_result,
354-
requirement_severity=Severity.RECOMMENDED,
355-
expected_validation_result=False,
356-
expected_triggered_requirements=["DownloadAction"],
357-
expected_triggered_issues=[
358-
(
359-
"The entity represented the downloaded workflow is not properly defined in the "
360-
"RO-Crate and/or it is not referenced by `DownloadAction` --> `result`."
361-
)
362-
],
363-
profile_identifier="five-safes-crate",
364-
rocrate_entity_mod_sparql=sparql,
365-
)
366-
367-
368-
def test_5src_downloaded_workflow_entity_is_not_of_type_dataset():
369-
sparql = (
370-
SPARQL_PREFIXES
371-
+ """
372-
DELETE {
373-
?wf rdf:type schema:Dataset .
374-
}
375-
INSERT {
376-
?wf rdf:type schema:Person .
377-
}
378-
WHERE {
379-
?wf rdf:type schema:Dataset .
380-
?da schema:result ?wf ;
381-
rdf:type schema:DownloadAction .
382-
}
383-
"""
384-
)
385-
386-
do_entity_test(
387-
rocrate_path=ValidROC().five_safes_crate_result,
388-
requirement_severity=Severity.RECOMMENDED,
389-
expected_validation_result=False,
390-
expected_triggered_requirements=["DownloadAction"],
391-
expected_triggered_issues=[
392-
(
393-
"The entity represented the downloaded workflow is not properly defined in the "
394-
"RO-Crate and/or it is not referenced by `DownloadAction` --> `result`."
395-
)
396-
],
397-
profile_identifier="five-safes-crate",
398-
rocrate_entity_mod_sparql=sparql,
399-
)
400-
401-
402335
def test_5src_download_action_does_not_have_action_status_property():
403336
sparql = (
404337
SPARQL_PREFIXES
@@ -451,8 +384,9 @@ def test_5src_downloaded_workflow_is_not_represented_by_its_own_entity():
451384
expected_triggered_requirements=["DownloadAction"],
452385
expected_triggered_issues=[
453386
(
454-
"The entity represented the downloaded workflow is not properly defined in the "
455-
"RO-Crate and/or it is not referenced by `DownloadAction` --> `result`."
387+
"The entity representing the downloaded workflow is not defined, "
388+
"OR is not referenced by `DownloadAction` --> `result`, "
389+
"OR is not of type `schema:Dataset`."
456390
)
457391
],
458392
profile_identifier="five-safes-crate",

0 commit comments

Comments
 (0)