Addressed Eli's comments

Author: EttoreM

tests/integration/profiles/five-safes-crate/test_valid_5src.py

@@ -26,17 +26,11 @@
 logger.setLevel(logging.DEBUG)
 
 # Dynamically fetch the SKIP_WEB_RESOURCE_AVAILABILITY_IDENTIFIER
-# required as disable_inherited_profiles_reporting does not disable Python checks from
-# inherited profiles (https://github.com/crs4/rocrate-validator/issues/135)
 rocrate_profile = services.get_profile("ro-crate-1.2")
 if not rocrate_profile:
     raise RuntimeError("Unable to load the RO-Crate 1.2 profile")
-check_local_data_entity_existence = rocrate_profile.get_requirement_check(
-    "Data Entity: REQUIRED resource availability"
-)
-assert check_local_data_entity_existence, (
-    "Unable to find the requirement 'Data Entity: REQUIRED resource availability'"
-)
+check_local_data_entity_existence = rocrate_profile.get_requirement_check("Data Entity: REQUIRED resource availability")
+assert check_local_data_entity_existence, "Unable to find the requirement 'Data Entity: REQUIRED resource availability'"
 SKIP_LOCAL_DATA_ENTITY_EXISTENCE_CHECK_IDENTIFIER = check_local_data_entity_existence.identifier
 check_local_data_entity_existence = rocrate_profile.get_requirement_check(
     "Web-based Data Entity: REQUIRED resource availability"

tests/integration/profiles/test_metadata_only.py

@@ -64,11 +64,9 @@ def test_valid_ro_crates_from_folder(valid_roc_path):
             [],
             profile_identifier=(
                 # ro-crate-1.1 can't be used for Five Safes crates as they conform to 1.2
-                "five-safes-crate"
-                if "five-safes-crate" in valid_roc_path.name
-                else DEFAULT_PROFILE_IDENTIFIER
+                "five-safes-crate" if "five-safes-crate" in valid_roc_path.name else DEFAULT_PROFILE_IDENTIFIER
             ),
-            metadata_only=True
+            metadata_only=True,
         )
 
 
@@ -90,10 +88,8 @@ def test_valid_ro_crates_from_metadata_dict(valid_roc_path):
             [],
             profile_identifier=(
                 # ro-crate-1.1 can't be used for Five Safes crates as they conform to 1.2
-                "five-safes-crate"
-                if "five-safes-crate" in valid_roc_path.name
-                else DEFAULT_PROFILE_IDENTIFIER
+                "five-safes-crate" if "five-safes-crate" in valid_roc_path.name else DEFAULT_PROFILE_IDENTIFIER
             ),
             metadata_dict=metadata_dict,
-            metadata_only=True
+            metadata_only=True,
         )

tests/shared.py

@@ -40,7 +40,6 @@
 PREFIX schema: <http://schema.org/>
 PREFIX shp:    <https://w3id.org/shp#>
 PREFIX rdf:    <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
-PREFIX rocrate: <https://github.com/crs4/rocrate-validator/profiles/ro-crate-1.2/>
 PREFIX dct: <http://purl.org/dc/terms/>
 """
 
@@ -95,12 +94,11 @@ def replace_uri_in_graph(graph, old_uri_str, new_uri_str):
 
     return g
 
+
 def _uses_https_schema(graph: rdflib.Graph) -> bool:
     for s, p, o in graph.triples((None, None, None)):
         for term in (s, p, o):
-            if isinstance(term, rdflib.URIRef) and str(term).startswith(
-                "https://schema.org/"
-            ):
+            if isinstance(term, rdflib.URIRef) and str(term).startswith("https://schema.org/"):
                 return True
     return False