Skip to content

Commit 964ff31

Browse files
committed
Addressed Eli's and Doug's comments.
1 parent 779022a commit 964ff31

5 files changed

Lines changed: 11 additions & 54 deletions

File tree

rocrate_validator/profiles/five-safes-crate/must/1_requesting_agent.ttl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,5 +78,5 @@ five-safes-crate:AgentProjectIntersection
7878
}
7979
""" ;
8080
sh:severity sh:Violation ;
81-
sh:message """Agent -> memberOf MUST intersect RootDataEntity -> sourceOrganization.""" ;
81+
sh:message """At least one Project referenced by Agent -> memberOf MUST be included in the set of Projects referenced by RootDataEntity -> sourceOrganization.""" ;
8282
] .

rocrate_validator/profiles/five-safes-crate/should/1_responsible_project.ttl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,5 @@ five-safes-crate:ResponsibleProjectMemberAndSourceOrganizationIntersection
5656
}
5757
""" ;
5858
sh:severity sh:Warning ;
59-
sh:message """Responsible Project --> member SHOULD intersect Requesting Agent --> affiliation.""" ;
59+
sh:message """At least one of the organisations that are members of the responsible project SHOULD be included in the Requesting Agent's affiliations, if such properties exist.""" ;
6060
] .

tests/integration/profiles/five-safes-crate/test_5src_1_requesting_agent.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,10 @@ def test_5src_agent_memberOf_project_not_in_root():
9595
expected_validation_result=False,
9696
expected_triggered_requirements=["Agent Project Intersection"],
9797
expected_triggered_issues=[
98-
"""Agent -> memberOf MUST intersect RootDataEntity -> sourceOrganization."""
98+
(
99+
"At least one Project referenced by Agent -> memberOf MUST be included "
100+
"in the set of Projects referenced by RootDataEntity -> sourceOrganization."
101+
)
99102
],
100103
profile_identifier="five-safes-crate",
101104
rocrate_entity_mod_sparql=sparql,

tests/integration/profiles/five-safes-crate/test_5src_1_responsible_project.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,7 @@ def test_5src_responsible_project_member_and_agent_affiliation_no_intersection()
126126
?agent a schema:Person ;
127127
schema:memberOf ?project ;
128128
schema:affiliation ?oldAff .
129-
?project schema:member ?org2 .
130-
131-
FILTER NOT EXISTS { ?project schema:member <#missing-affiliation> }
129+
?project schema:member ?oldAff .
132130
}
133131
"""
134132
)
@@ -141,7 +139,10 @@ def test_5src_responsible_project_member_and_agent_affiliation_no_intersection()
141139
"Organizations (members of Responsible Project)"
142140
],
143141
expected_triggered_issues=[
144-
"Responsible Project --> member SHOULD intersect Requesting Agent --> affiliation."
142+
(
143+
"At least one of the organisations that are members of the responsible project SHOULD "
144+
"be included in the Requesting Agent's affiliations, if such properties exist."
145+
)
145146
],
146147
profile_identifier="five-safes-crate",
147148
rocrate_entity_mod_sparql=sparql,

tests/integration/profiles/five-safes-crate/test_5src_funding.py

Lines changed: 0 additions & 47 deletions
This file was deleted.

0 commit comments

Comments
 (0)