Skip to content

Commit ba3524e

Browse files
committed
update sign-off startTime test, and move severity out of library code
1 parent 7f1b0cc commit ba3524e

3 files changed

Lines changed: 10 additions & 33 deletions

File tree

rocrate_validator/profiles/five-safes-crate/may/4_sign_off.ttl

Lines changed: 8 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -25,34 +25,12 @@
2525

2626
five-safes-crate:SignOffPhaseStartTime
2727
a sh:NodeShape ;
28-
sh:name "SignOffPhaseStartTime" ;
29-
30-
sh:target [
31-
a sh:SPARQLTarget ;
32-
sh:select """
33-
PREFIX schema: <http://schema.org/>
34-
PREFIX shp: <https://w3id.org/shp#>
35-
SELECT ?this
36-
WHERE {
37-
?this schema:additionalType shp:SignOff ;
38-
schema:actionStatus ?status .
39-
FILTER(?status IN (
40-
"http://schema.org/ActiveActionStatus",
41-
"http://schema.org/CompletedActionStatus",
42-
"http://schema.org/FailedActionStatus"
43-
))
44-
}
45-
""" ;
28+
sh:description "Sign Off start time check" ;
29+
sh:node five-safes-crate:StartTimeStamp ;
30+
sh:severity sh:Info ;
31+
sh:target [
32+
a five-safes-crate:ActionActiveCompFailSearch ;
33+
five-safes-crate:addtype shp:SignOff ;
4634
] ;
47-
48-
sh:property [
49-
a sh:PropertyShape ;
50-
sh:name "StartTime" ;
51-
sh:path schema:startTime ;
52-
sh:minCount 1 ;
53-
sh:maxCount 1 ;
54-
sh:pattern "^[0-9]{4}-[0-9]{2}-[0-9]{2}[Tt][0-9]{2}:[0-9]{2}:[0-9]{2}([.|,][0-9]+)?(Z|z|[+-][0-9]{2}:[0-9]{2})$" ;
55-
sh:severity sh:Info ;
56-
sh:description "Sign Off object MAY have a startTime property if action is active, completed or failed. This must follow ISO-8601 syntax" ;
57-
sh:message "Sign Off object MAY have a startTime property if action is active, completed or failed. This must follow ISO-8601 syntax" ;
58-
] .
35+
sh:message "Sign Off phase MAY have a compliant startTime if action is active, completed or failed."
36+
.

rocrate_validator/profiles/five-safes-crate/shape_library.ttl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ five-safes-crate:EndTimeStamp
3434
sh:minCount 1 ;
3535
sh:maxCount 1 ;
3636
sh:name "EndTimeStamp" ;
37-
sh:severity sh:Warning ;
3837
sh:message "endTime property MUST follow ISO-8601 syntax. e.g. 2023-04-19T10:15:12+01:00" ;
3938
] .
4039

@@ -48,8 +47,7 @@ five-safes-crate:StartTimeStamp
4847
sh:path schema:startTime ;
4948
sh:minCount 1 ;
5049
sh:maxCount 1 ;
51-
sh:name "EndTime" ;
52-
sh:severity sh:Warning ;
50+
sh:name "StartTime" ;
5351
sh:message "startTime property MUST follow ISO-8601 syntax. e.g. 2023-04-19T10:15:12+01:00" ;
5452
] .
5553

rocrate_validator/profiles/five-safes-crate/should/4_sign_off.ttl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ five-safes-crate:SignOffPhaseEndTime
151151
a sh:NodeShape ;
152152
sh:description "Sign Off end time check" ;
153153
sh:node five-safes-crate:EndTimeStamp ;
154+
sh:severity sh:Warning ;
154155
sh:target [
155156
a five-safes-crate:ActionCompFailSearch ;
156157
five-safes-crate:addtype shp:SignOff ;

0 commit comments

Comments
 (0)