fix(shacl): 🐛 evaluate inherited shapes for zero-shape target profiles

Override `SHACLRequirement.finalize` to force one pyshacl run on the
merged shapes graph when the target profile contributes no SHACL checks
of its own (e.g. extension profiles that purely inherit or only
deactivate). Without it, the main loop never triggers a SHACL run and
inherited shapes are silently skipped.

Author: kikkomep

rocrate_validator/requirements/shacl/requirements.py

@@ -19,8 +19,14 @@
 
 from rocrate_validator.utils import log as logging
 from rocrate_validator.constants import VALIDATOR_NS
-from rocrate_validator.models import (Profile, Requirement, RequirementCheck,
-                                      RequirementLevel, RequirementLoader)
+from rocrate_validator.models import (
+    Profile,
+    Requirement,
+    RequirementCheck,
+    RequirementLevel,
+    RequirementLoader,
+    ValidationContext,
+)
 from rocrate_validator.requirements.shacl.checks import SHACLCheck
 from rocrate_validator.requirements.shacl.models import Shape, ShapesRegistry
 
@@ -82,9 +88,67 @@ def hidden(self) -> bool:
                 return True
         return False
 
+    @classmethod
+    def finalize(cls, context: ValidationContext) -> None:
+        """ "
+        Finalize the SHACL requirement by ensuring that a SHACL validation run is triggered for the target profile
+        if it has no shapes of its own (e.g. an extension profile that purely inherits or only deactivates).
+
+        SHACL is normally driven by the first execute_check of a check
+        belonging to the target profile (see SHACLValidationContextManager).
+        If the target has zero SHACL checks of its own (e.g. an extension
+        profile that purely inherits or only deactivates), no pyshacl run
+        is ever triggered and inherited shapes are never evaluated.
+        Force one final run on the merged shapes graph in that case.
+        """
+
+        logger.debug("Starting %s requirement finalization for context %s", cls.__name__, context)
+
+        # extract profiles and target profile from context
+        profiles = context.profiles
+
+        from rocrate_validator.requirements.shacl.checks import SHACLCheck
+        from rocrate_validator.requirements.shacl.validator import SHACLValidationContext
+
+        target = next((p for p in profiles if p.identifier == context.settings.profile_identifier), None)
+        if target is None:
+            return
+
+        shacl_context = SHACLValidationContext.get_instance(context)
+        # If pyshacl already ran for the target during the main loop there is
+        # nothing to do.
+        if shacl_context.get_validation_result(target) is not None:
+            return
+
+        # Pick any SHACLCheck across the loaded profiles to drive the run; the
+        # check identity is only used for logging inside __do_execute_check__,
+        # the actual validation is graph-wide.
+        runner = next(
+            (c for p in profiles for r in p.requirements for c in r.get_checks() if isinstance(c, SHACLCheck)),
+            None,
+        )
+        if runner is None:
+            return
+
+        # Make sure the target's shapes (if any) are in the merged registry
+        # and switch the current profile so violations are attributed under
+        # the target profile in the report.
+        shacl_context.__set_current_validation_profile__(target)
+        shacl_context._current_validation_profile = target
+        try:
+            runner.__do_execute_check__(shacl_context)
+        except Exception as e:
+            logger.warning("Forced SHACL run for zero-shape target profile %s failed: %s", target.identifier, e)
+            if logger.isEnabledFor(logging.DEBUG):
+                logger.exception(e)
+        finally:
+            shacl_context.__unset_current_validation_profile__()
+
+        # do finalization logic here (empty for now)
+        logger.debug("Completed %s requirement finalization for context %s", cls.__name__, context)
 
-class SHACLRequirementLoader(RequirementLoader):
 
+class SHACLRequirementLoader(RequirementLoader):
     def __init__(self, profile: Profile):
         super().__init__(profile)
         self._shape_registry = ShapesRegistry.get_instance(profile)