incomplete time test code

Author: douglowe

rocrate_validator/profiles/five-safes-crate/shape_library.ttl

@@ -0,0 +1,72 @@
+# Copyright (c) 2025 eScience Lab, The University of Manchester
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+@prefix ro: <./> .
+@prefix ro-crate: <https://github.com/crs4/rocrate-validator/profiles/ro-crate/> .
+@prefix five-safes-crate: <https://github.com/eScienceLab/rocrate-validator/profiles/five-safes-crate/> .
+@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
+@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
+@prefix schema: <http://schema.org/> .
+@prefix sh: <http://www.w3.org/ns/shacl#> .
+@prefix validator: <https://github.com/crs4/rocrate-validator/> .
+@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+@prefix shp: <https://w3id.org/shp#> .
+
+
+
+
+
+five-safes-crate:TimeStamp
+    a sh:NodeShape ;
+    sh:datatype xsd:string ;
+    sh:pattern "^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}(Z|[+-][0-9]{2}:[0-9]{2})$" .
+
+
+
+five-safes-crate:EndTimeStamp
+    a sh:NodeShape ;
+    sh:property [
+        sh:node five-safes-crate:TimeStamp ;
+        sh:description "End Time Check" ;
+        sh:path schema:endTime ;
+        sh:minCount 1 ;
+        sh:maxCount 1 ;
+        sh:name "EndTime" ;
+        sh:severity sh:Warning ;
+        sh:message "Object SHOULD have endTime property if action completed or failed. This must follow ISO-8601 syntax" ;
+    ] .
+
+
+five-safes-crate:EndTimeSearch
+    a sh:SPARQLTargetType ;
+    rdfs:subClassOf sh:Target ;
+    sh:parameter [
+        sh:path five-safes-crate:addtype ;
+        sh:description "Additional Type for Class" ;
+        sh:class sh:additionalType ;
+    ] ;
+    sh:select """
+        PREFIX schema: <http://schema.org/>
+        PREFIX shp:    <https://w3id.org/shp#>
+        SELECT ?this
+        WHERE {
+            ?this schema:additionalType $addtype ;
+                    schema:actionStatus ?status .
+            FILTER(?status IN (
+                "http://schema.org/CompletedActionStatus",
+                "http://schema.org/FailedActionStatus"
+            ))
+        }
+    """ .
+

rocrate_validator/profiles/five-safes-crate/should/4_sign_off.ttl

@@ -22,6 +22,9 @@
 @prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
 @prefix shp: <https://w3id.org/shp#> .
 
+<> a sh:ShapesGraph ;
+    sh:import <../shape_library.ttl> .
+
 
 # There SHOULD be a Sign-Off Phase
 five-safes-crate:SignOffPhase
@@ -146,32 +149,10 @@ five-safes-crate:SignOffPhaseProperties
 five-safes-crate:SignOffPhaseEndTime
     a sh:NodeShape ;
     sh:description "Sign Off end time check" ;
+    sh:node five-safes-crate:EndTimeStamp ;
+    sh:target [ 
+        a five-safes-crate:EndTimeSearch ;
+        sh:additionalType shp:SignOff ;
+    ].
 
-    sh:target [
-        a sh:SPARQLTarget ;
-        sh:select """
-            PREFIX schema: <http://schema.org/>
-            PREFIX shp:    <https://w3id.org/shp#>
-            SELECT ?this
-            WHERE {
-                ?this schema:additionalType shp:SignOff ;
-                        schema:actionStatus ?status .
-                FILTER(?status IN (
-                    "http://schema.org/CompletedActionStatus",
-                    "http://schema.org/FailedActionStatus"
-                ))
-            }
-        """ ;
-    ] ;
 
-    sh:property [
-        a sh:PropertyShape ;
-        sh:name "EndTime" ;
-        sh:path schema:endTime ;
-        sh:minCount 1 ;
-        sh:maxCount 1 ;
-        sh:pattern "^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}(Z|[+-][0-9]{2}:[0-9]{2})$" ;
-        sh:severity sh:Warning ;
-        sh:description "Sign Off object SHOULD have endTime property if action completed or failed. This must follow ISO-8601 syntax" ;
-        sh:message "Sign Off object SHOULD have endTime property if action completed or failed. This must follow ISO-8601 syntax" ;
-    ] .