tests for TRE policy instrument

Author: douglowe

rocrate_validator/profiles/five-safes-crate/should/4_sign_off.ttl

@@ -98,11 +98,13 @@ five-safes-crate:SignOffPhaseProperties
         sh:message "The Sign-Off Phase SHOULD have an agent" ;
     ] ;
     sh:property [
-        sh:description "Check if the Sign Off phase has an instrument" ;
+        sh:description "Check if the Sign Off phase has an instrument (TRE Policy)" ;
         sh:path schema:instrument ;
+        sh:class schema:CreativeWork ;
+        sh:hasValue schema:name ;
         sh:minCount 1 ;
         sh:severity sh:Warning ;
-        sh:message "The Sign-Off Phase SHOULD have an instrument" ;
+        sh:message "The Sign-Off Phase SHOULD have an TRE policy (instrument) with type CreativeWork and human-readable name" ;
     ] .
 
 

tests/integration/profiles/five-safes-crate/test_5src_signoff_phase.py

@@ -179,7 +179,7 @@ def test_5src_signoff_phase_no_agent():
 
 def test_5src_signoff_phase_no_instrument():
     """
-    Test a Five Safes Crate where the Sign-Off phase has no instrument.
+    Test a Five Safes Crate where the Sign-Off phase has no TRE policy (instrument).
     """
     sparql = (
         SPARQL_PREFIXES
@@ -201,7 +201,71 @@ def test_5src_signoff_phase_no_instrument():
         expected_validation_result=False,
         expected_triggered_requirements=["SignOffPhaseProperties"],
         expected_triggered_issues=[
-            "The Sign-Off Phase SHOULD have an instrument"
+            "The Sign-Off Phase SHOULD have an TRE policy (instrument) with type CreativeWork and human-readable name"
+        ],
+        profile_identifier="five-safes-crate",
+        rocrate_entity_mod_sparql=sparql,
+    )
+
+
+def test_5src_signoff_phase_instrument_no_type():
+    """
+    Test a Five Safes Crate where the Sign-Off phase instrument has no type.
+    """
+    sparql = (
+        SPARQL_PREFIXES
+        + """
+        DELETE {
+            ?instrument rdf:type ?type .
+        }
+        WHERE {
+           ?signoff a schema:AssessAction ;
+               schema:additionalType <https://w3id.org/shp#SignOff> ;
+               schema:instrument ?instrument .
+            ?instrument rdf:type ?type .
+        }
+        """
+    )
+
+    do_entity_test(
+        rocrate_path=ValidROC().five_safes_crate_result,
+        requirement_severity=Severity.RECOMMENDED,
+        expected_validation_result=False,
+        expected_triggered_requirements=["SignOffPhaseProperties"],
+        expected_triggered_issues=[
+            "The Sign-Off Phase SHOULD have an TRE policy (instrument) with type CreativeWork and human-readable name"
+        ],
+        profile_identifier="five-safes-crate",
+        rocrate_entity_mod_sparql=sparql,
+    )
+
+
+def test_5src_signoff_phase_instrument_no_name():
+    """
+    Test a Five Safes Crate where the Sign-Off phase instrument has no type.
+    """
+    sparql = (
+        SPARQL_PREFIXES
+        + """
+        DELETE {
+            ?instrument schema:name ?name .
+        }
+        WHERE {
+           ?signoff a schema:AssessAction ;
+               schema:additionalType <https://w3id.org/shp#SignOff> ;
+               schema:instrument ?instrument .
+            ?instrument schema:name ?name .
+        }
+        """
+    )
+
+    do_entity_test(
+        rocrate_path=ValidROC().five_safes_crate_result,
+        requirement_severity=Severity.RECOMMENDED,
+        expected_validation_result=False,
+        expected_triggered_requirements=["SignOffPhaseProperties"],
+        expected_triggered_issues=[
+            "The Sign-Off Phase SHOULD have an TRE policy (instrument) with type CreativeWork and human-readable name"
         ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,