sign-off instrument check

Author: douglowe

rocrate_validator/profiles/five-safes-crate/should/4_sign_off.ttl

@@ -96,6 +96,13 @@ five-safes-crate:SignOffPhaseProperties
         sh:minCount 1 ;
         sh:severity sh:Warning ;
         sh:message "The Sign-Off Phase SHOULD have an agent" ;
+    ] ;
+    sh:property [
+        sh:description "Check if the Sign Off phase has an instrument" ;
+        sh:path schema:instrument ;
+        sh:minCount 1 ;
+        sh:severity sh:Warning ;
+        sh:message "The Sign-Off Phase SHOULD have an instrument" ;
     ] .
 
 

tests/integration/profiles/five-safes-crate/test_5src_signoff_phase.py

@@ -174,4 +174,35 @@ def test_5src_signoff_phase_no_agent():
         ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,
-    )
+    )
+
+
+def test_5src_signoff_phase_no_instrument():
+    """
+    Test a Five Safes Crate where the Sign-Off phase has no instrument.
+    """
+    sparql = (
+        SPARQL_PREFIXES
+        + """
+        DELETE {
+            ?signoff schema:instrument ?instrument .
+        }
+        WHERE {
+           ?signoff a schema:AssessAction ;
+               schema:additionalType <https://w3id.org/shp#SignOff> ;
+               schema:instrument ?instrument .
+        }
+        """
+    )
+
+    do_entity_test(
+        rocrate_path=ValidROC().five_safes_crate_result,
+        requirement_severity=Severity.RECOMMENDED,
+        expected_validation_result=False,
+        expected_triggered_requirements=["SignOffPhaseProperties"],
+        expected_triggered_issues=[
+            "The Sign-Off Phase SHOULD have an instrument"
+        ],
+        profile_identifier="five-safes-crate",
+        rocrate_entity_mod_sparql=sparql,
+    )