test(rocrate): ✅ test data entities with external references are classified as remote

Author: kikkomep

tests/unit/test_rocrate.py

@@ -556,20 +556,74 @@ def test_entity_path_from_identifier():
     quoted_entity_id = "pics/2017-06-11%2012.56.14.jpg"
     path = ROCrateEntity.get_path_from_identifier(quoted_entity_id, rocrate_path=rocrate_path)
     logger.debug(f"Quoted Entity Path: {path}")
-    assert str(path) == f"{rocrate_path}/pics/2017-06-11%2012.56.14.jpg", \
+    assert str(path) == f"{rocrate_path}/pics/2017-06-11%2012.56.14.jpg", (
         "Path should be pics/2017-06-11%2012.56.14.jpg"
+    )
 
     # Test quoted entity id which does not exist within the ro-crate
     quoted_entity_id = "pics/2018-06-11%2012.56.14.jpg"
-    path = ROCrateEntity.get_path_from_identifier(
-        quoted_entity_id, rocrate_path=rocrate_path, decode=True)
+    path = ROCrateEntity.get_path_from_identifier(quoted_entity_id, rocrate_path=rocrate_path, decode=True)
     logger.debug(f"Quoted Entity Path: {path}")
-    assert str(path) == f"{rocrate_path}/pics/2018-06-11 12.56.14.jpg", \
-        "Path should be pics/2018-06-11 12.56.14.jpg"
+    assert str(path) == f"{rocrate_path}/pics/2018-06-11 12.56.14.jpg", "Path should be pics/2018-06-11 12.56.14.jpg"
 
     # Test unquoted entity id which exists within the ro-crate
     unquoted_entity_id = "pics/2017-06-11 12.56.14.jpg"
     path = ROCrateEntity.get_path_from_identifier(unquoted_entity_id, rocrate_path=rocrate_path)
     logger.debug(f"Unquoted Entity Path: {path}")
-    assert str(path) == f"{rocrate_path}/pics/2017-06-11 12.56.14.jpg", \
-        "Path should be pics/2017-06-11 12.56.14.jpg"
+    assert str(path) == f"{rocrate_path}/pics/2017-06-11 12.56.14.jpg", "Path should be pics/2017-06-11 12.56.14.jpg"
+
+
+def _metadata_dict_with_id(entity_id: str) -> dict:
+    """Build a minimal RO-Crate metadata dict referencing a single data entity."""
+    return {
+        "@context": "https://w3id.org/ro/crate/1.1/context",
+        "@graph": [
+            {
+                "@id": "ro-crate-metadata.json",
+                "@type": "CreativeWork",
+                "conformsTo": {"@id": "https://w3id.org/ro/crate/1.1"},
+                "about": {"@id": "./"},
+            },
+            {
+                "@id": "./",
+                "@type": "Dataset",
+                "name": "Test crate",
+                "hasPart": [{"@id": entity_id}],
+            },
+            {"@id": entity_id, "@type": "File", "name": "remote-file"},
+        ],
+    }
+
+
+@pytest.mark.parametrize(
+    "entity_id",
+    [
+        # authority-based absolute URIs (with a `//` authority component)
+        "scp://transfer.example.org//data/A.0.0",
+        "sftp://user@host/path/to/file",
+        "s3://bucket/key",
+        "https://example.org/data.txt",
+        "arcp://name,foo/bar",
+        # scheme-only absolute URIs (no authority; RO-Crate 1.1 § 4.2.2 + RFC 3986)
+        "urn:doi:10.5281/zenodo.1234",
+        "doi:10.5281/zenodo.1234",
+    ],
+)
+def test_absolute_uri_data_entity_is_classified_as_remote(entity_id):
+    """
+    Data entities whose @id is an absolute URI (any non-file scheme, with or
+    without authority) MUST be recognized as remote (web-based) data entities
+    so that the must/4 payload check is skipped for them.
+
+    Regression test for issue #176.
+    """
+    crate = ROCrate.from_metadata_dict(_metadata_dict_with_id(entity_id))
+    entity = crate.metadata.get_entity(entity_id)
+    assert entity is not None, "Entity should be present in the metadata"
+    assert entity.is_remote(), f"Entity with absolute URI '{entity_id}' should be classified as remote"
+    assert entity in crate.metadata.get_web_data_entities(), (
+        f"Entity '{entity_id}' should be listed as a web data entity"
+    )
+    assert entity not in crate.metadata.get_data_entities(exclude_web_data_entities=True), (
+        f"Entity '{entity_id}' should be excluded from local-only data entities"
+    )