Addressed Doug's comments on this PR.

Author: EttoreM

rocrate_validator/profiles/five-safes-crate/must/12_check_phase.ttl

@@ -52,12 +52,11 @@ five-safes-crate:CheckValueObjectHasDescriptiveNameAndIsAssessAction
     sh:property [
         sh:a sh:PropertyShape ;
         sh:name "name" ;
-        sh:description "CheckValue MUST have a human readable name string of at least 20 characters." ;
+        sh:description "CheckValue MUST have a human readable name string." ;
         sh:path schema:name ;
         sh:datatype xsd:string ;
-        sh:minLength 20 ;
         sh:severity sh:Violation ;
-        sh:message "CheckValue MUST have a human readable name string of at least 20 characters." ;
+        sh:message "CheckValue MUST have a human readable name string." ;
     ] .
 
 five-safes-crate:CheckValueStartTimeMustFollowISOStandard

rocrate_validator/profiles/five-safes-crate/should/12_check_phase.ttl

@@ -70,7 +70,7 @@ five-safes-crate:CheckValueObjectShouldPointToRootDataEntity
         sh:name "object" ;
         sh:path schema:object ;
         sh:minCount 1 ;
-        sh:hasValue <./> ;
+        sh:hasValue ro-crate:RootDataEntity ;
         sh:severity sh:Warning ;
         sh:message "`CheckValue` --> `object` SHOULD point to the root of the RO-Crate" ;
     ] .

tests/integration/profiles/five-safes-crate/test_5src_12_check_phase.py

@@ -24,6 +24,7 @@
 
 # ----- MUST fails tests
 
+
 # TO BE CHECKED AGAIN
 def test_5src_check_value_not_of_type_assess_action():
     sparql = """
@@ -65,7 +66,7 @@ def test_5src_check_value_name_not_a_string():
             ?this schema:name ?name .
         }
         INSERT {
-            ?this schema:name 123 .
+            ?this schema:name "123"^^xsd:integer .
         }
         WHERE {
             ?this schema:additionalType shp:CheckValue .
@@ -77,35 +78,9 @@ def test_5src_check_value_name_not_a_string():
         requirement_severity=Severity.REQUIRED,
         expected_validation_result=False,
         expected_triggered_requirements=["CheckValue"],
-        expected_triggered_issues=["CheckValue MUST have a human readable name string of at least 20 characters."],
-        profile_identifier="five-safes-crate",
-        rocrate_entity_mod_sparql=sparql,
-    )
-
-
-def test_5src_check_value_name_not_long_enough():
-    sparql = """
-        PREFIX schema: <http://schema.org/>
-        PREFIX shp:    <https://w3id.org/shp#>
-        PREFIX rdf:    <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
-
-        DELETE {
-            ?this schema:name ?name .
-        }
-        INSERT {
-            ?this schema:name "Short" .
-        }
-        WHERE {
-            ?this schema:additionalType shp:CheckValue .
-        }
-        """
-
-    do_entity_test(
-        rocrate_path=ValidROC().five_safes_crate_result,
-        requirement_severity=Severity.REQUIRED,
-        expected_validation_result=False,
-        expected_triggered_requirements=["CheckValue"],
-        expected_triggered_issues=["CheckValue MUST have a human readable name string of at least 20 characters."],
+        expected_triggered_issues=[
+            "CheckValue MUST have a human readable name string."
+        ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,
     )
@@ -134,10 +109,12 @@ def test_5src_check_value_start_time_not_iso_standard():
         requirement_severity=Severity.REQUIRED,
         expected_validation_result=False,
         expected_triggered_requirements=["CheckValue"],
-        expected_triggered_issues=[(
-            "`CheckValue` --> `startTime` MUST follows the RFC 3339 standard "
-            "(YYYY-MM-DD'T'hh:mm:ss[.fraction](Z | ±hh:mm))."
-        )],
+        expected_triggered_issues=[
+            (
+                "`CheckValue` --> `startTime` MUST follows the RFC 3339 standard "
+                "(YYYY-MM-DD'T'hh:mm:ss[.fraction](Z | ±hh:mm))."
+            )
+        ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,
     )
@@ -166,10 +143,12 @@ def test_5src_check_value_end_time_not_iso_standard():
         requirement_severity=Severity.REQUIRED,
         expected_validation_result=False,
         expected_triggered_requirements=["CheckValue"],
-        expected_triggered_issues=[(
-            "`CheckValue` --> `endTime` MUST follows the RFC 3339 standard "
-            "(YYYY-MM-DD'T'hh:mm:ss[.fraction](Z | ±hh:mm))."
-        )],
+        expected_triggered_issues=[
+            (
+                "`CheckValue` --> `endTime` MUST follows the RFC 3339 standard "
+                "(YYYY-MM-DD'T'hh:mm:ss[.fraction](Z | ±hh:mm))."
+            )
+        ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,
     )
@@ -198,14 +177,17 @@ def test_5src_check_value_has_action_status_with_not_allowed_value():
         requirement_severity=Severity.REQUIRED,
         expected_validation_result=False,
         expected_triggered_requirements=["CheckValue"],
-        expected_triggered_issues=["`CheckValue` --> `actionStatus` MUST have one of the allowed values."],
+        expected_triggered_issues=[
+            "`CheckValue` --> `actionStatus` MUST have one of the allowed values."
+        ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,
     )
 
 
 # ----- SHOULD fails tests
 
+
 def test_5src_root_data_entity_does_not_mention_check_value_entity():
     sparql = """
         PREFIX schema: <http://schema.org/>
@@ -224,7 +206,9 @@ def test_5src_root_data_entity_does_not_mention_check_value_entity():
         requirement_severity=Severity.RECOMMENDED,
         expected_validation_result=False,
         expected_triggered_requirements=["RootDataEntity"],
-        expected_triggered_issues=["RootDataEntity SHOULD mention a check value object."],
+        expected_triggered_issues=[
+            "RootDataEntity SHOULD mention a check value object."
+        ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,
     )
@@ -251,7 +235,9 @@ def test_5src_check_value_object_does_not_point_to_root_data_entity():
         requirement_severity=Severity.RECOMMENDED,
         expected_validation_result=False,
         expected_triggered_requirements=["CheckValue"],
-        expected_triggered_issues=["`CheckValue` --> `object` SHOULD point to the root of the RO-Crate"],
+        expected_triggered_issues=[
+            "`CheckValue` --> `object` SHOULD point to the root of the RO-Crate"
+        ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,
     )
@@ -283,7 +269,7 @@ def test_5src_check_value_instrument_does_not_point_to_entity_with_type_defined_
         expected_triggered_requirements=["CheckValue"],
         expected_triggered_issues=[
             "`CheckValue` --> `instrument` SHOULD point to an entity typed `schema:DefinedTerm`"
-            ],
+        ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,
     )
@@ -361,14 +347,17 @@ def test_5src_check_value_does_not_point_to_an_agent():
         requirement_severity=Severity.RECOMMENDED,
         expected_validation_result=False,
         expected_triggered_requirements=["CheckValue"],
-        expected_triggered_issues=["`CheckValue` --> `agent` SHOULD reference the agent who initiated the check"],
+        expected_triggered_issues=[
+            "`CheckValue` --> `agent` SHOULD reference the agent who initiated the check"
+        ],
         profile_identifier="five-safes-crate",
         rocrate_entity_mod_sparql=sparql,
     )
 
 
 # ----- MAY fails tests
 
+
 def test_5src_check_value_does_not_have_start_time():
     sparql = """
         PREFIX schema: <http://schema.org/>