Closed
Conversation
Author
|
@elichad @douglowe @stain @alexhambley I think this PR is ready for review. |
alexhambley
reviewed
Oct 30, 2025
alexhambley
reviewed
Oct 30, 2025
| sh:message "The mainEntity pointed to by the RootDataEntity MUST be of type schema:Dataset" ; | ||
| ] . | ||
|
|
||
| five-safes-crate:mainEntityHasProperConformsTo |
There was a problem hiding this comment.
I'm not 100% sure, but I think this may only validate the prefix when conformsTo exists. In other words if conformsTo is missing, the violation might not report (?)
sh:minCount 1 ; might be required. Worth a test to see.
Author
There was a problem hiding this comment.
You're right. Added a constraint for that and a corresponding test.
alexhambley
requested changes
Oct 30, 2025
alexhambley
left a comment
There was a problem hiding this comment.
Provided comments in-line. There is a double colon typo and conformsTo property needs checking :)
|
This is superceded by PR #28 |
|
We've merged the replacement PR, so closing this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rules implemented
Rules NOT implemented
There are other rules pertaining to the mainEntity, but these were deemed to be not implementable.
For sake of completeness these are reported below