Implemented rules for the Workflow Execution Phase. - #41
Merged
Conversation
…orkflow Execution Phase.
EttoreM
marked this pull request as ready for review
November 27, 2025 15:27
elichad
requested changes
Dec 5, 2025
elichad
left a comment
elichad
left a comment
There was a problem hiding this comment.
I found some issues with the tests - but the SHACL looks good to me, so hopefully there are no major issues hiding :)
Aside from that, just a few small tweaks suggested.
elichad
reviewed
Dec 5, 2025
elichad
approved these changes
Dec 8, 2025
elichad
left a comment
elichad
left a comment
There was a problem hiding this comment.
One more suggestion - just a simplification to make future maintenance easier.
Otherwise, this looks good to me, so approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #37
Rules implemented
(i) The Workflow Execution object is the only entity in this phase that is typed
schema:CreateAction.(ii) This was implemented by requiring that the name of the Workflow Execution object is of type string and is at least 10 characters long.
(iii) This rule is implemented implicitly within the others. For example the RootDataEntity MUST mention a CreateAction entity which is assumed to be the Workflow Execution object in this phase (there is only one CreateAction object in the crate's graph).