Cleanup distribution and installer jobs#6460
Merged
Merged
Conversation
milton is test only resource
- drop outdated setFile method, - allign macOS min version with the one supported by Java 21 - make path expressions less brittle
Move appbundler-maven-plugin from the main build into the mac-dmg-on-mac profile so it is only invoked on macOS. Extend skip-build-dist-archives to set skip.mac.dist=true, in the appbundler and both exec-maven-plugin DMG executions, suppressing .app and DMG creation alongside the zip/tar archives. Update AGENTS.md to document the profile activation rules and opt-out flags.
Introduce a mac.bundle.phase property (default: none) that binds all *-for-mac-bundle plugin executions to no lifecycle phase by default, making them no-ops on Linux CI and Windows where no DMG is produced. The mac-dmg-on-mac and mac-dmg-on-unix profiles override this to package, re-enabling the tasks only when a DMG build is actually taking place. Split delete-jetty-dest-before-rename into two executions so the appassembler cleanup remains unconditional while the mac-bundle counterpart follows the same mac.bundle.phase gate.
powerpc no longer supported
no need to build on mac CI
dizzzz
approved these changes
Jun 10, 2026
Member
Contributor
Author
|
@joewiz no this doesn't change how the dmg locates system JVM. If we want to include a jdk in the dmg, that PR would supersede yours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup remove dead stuff, and avoid unnecessary artefact generation.
Fix Installer.jar generation and publishing.